Re: [kubernetes/kubernetes] volume: move unimplemented VolumeHost methods into a single struct (#63952)
k8s-ci-robot
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mikedanese
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: saad-ali
Assign the PR to them by writing /assign @saad-ali in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:pkg/controller/volume/attachdetach/OWNERS[mikedanese]pkg/controller/volume/expand/OWNERS[mikedanese]pkg/controller/volume/persistentvolume/OWNERS[mikedanese]- pkg/volume/OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Mike Danese
This reduces duplication, making it easier to expand the VolumeHost interface in the future.
NONE
@kubernetes/sig-storage-pr-reviews
You can view, comment on, or merge this pull request online at:
https://github.com/kubernetes/kubernetes/pull/63952
Commit Summary
- volume: move unimplemented VolumeHost methods into a single struct
File Changes
- M pkg/controller/volume/attachdetach/BUILD (2)
- M pkg/controller/volume/attachdetach/attach_detach_controller.go (110)
- M pkg/controller/volume/attachdetach/attach_detach_controller_test.go (2)
- M pkg/controller/volume/expand/BUILD (3)
- M pkg/controller/volume/expand/expand_controller.go (112)
- M pkg/controller/volume/persistentvolume/BUILD (4)
- M pkg/controller/volume/persistentvolume/pv_controller.go (2)
- D pkg/controller/volume/persistentvolume/volume_host.go (123)
- M pkg/volume/plugins.go (94)
Patch Links:
- https://github.com/kubernetes/kubernetes/pull/63952.patch
- https://github.com/kubernetes/kubernetes/pull/63952.diff
k8s-ci-robot
@mikedanese: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pull-kubernetes-bazel-test | eac7889 | link | /test pull-kubernetes-bazel-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce | eac7889 | link | /test pull-kubernetes-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | eac7889 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce | eac7889 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-kubemark-e2e-gce-big | eac7889 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | eac7889 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce | eac7889 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-kubemark-e2e-gce-big | eac7889 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-gce-device-plugin-gpu | eac7889 | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce | eac7889 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-kubemark-e2e-gce-big | eac7889 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-gce-device-plugin-gpu | eac7889 | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
| pull-kubernetes-integration | 36df711 | link | /test pull-kubernetes-integration |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce | eac7889 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-kubemark-e2e-gce-big | eac7889 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-kops-aws | 36df711 | link | /test pull-kubernetes-e2e-kops-aws |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | eac7889 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-integration | 36df711 | link | /test pull-kubernetes-integration |
| pull-kubernetes-e2e-kops-aws | 36df711 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-e2e-gce | 36df711 | link | /test pull-kubernetes-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
Andrew Lytvynov
@awly commented on this pull request.
> @@ -826,3 +827,98 @@ type dummyPluginProber struct{}
func (*dummyPluginProber) Init() error { return nil }
func (*dummyPluginProber) Probe() ([]ProbeEvent, error) { return nil, nil }
+
+// UnimplementedVolumeHost is a fully unimplemented implementation of
+// VolumeHost interface. This is useful for embedding in many partial
+// implementations of VolumeHost we have.
+type UnimplementedVolumeHost struct{}
+
+var _ = VolumeHost(&UnimplementedVolumeHost{})
+
+func (*UnimplementedVolumeHost) GetPluginDir(pluginName string) string {
Make all the receivers non-pointers
Andrew Lytvynov
The failing tests have lots of Volume references. Could be related to your change
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-integration | 36df711 | link | /test pull-kubernetes-integration |
| pull-kubernetes-e2e-kops-aws | 36df711 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-e2e-gce | 36df711 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-bazel-build | e132327 | link | /test pull-kubernetes-bazel-build |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce | 36df711 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-bazel-build | e132327 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-kops-aws | e132327 | link | /test pull-kubernetes-e2e-kops-aws |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-integration | 36df711 | link | /test pull-kubernetes-integration |
| pull-kubernetes-e2e-gce | 36df711 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-bazel-build | e132327 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-kops-aws | e132327 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-e2e-gce-device-plugin-gpu | e132327 | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-build | e132327 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-kops-aws | e132327 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-e2e-gce-device-plugin-gpu | e132327 | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
| pull-kubernetes-e2e-gce | e132327 | link | /test pull-kubernetes-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-kops-aws | e132327 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-e2e-gce-device-plugin-gpu | e132327 | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
| pull-kubernetes-e2e-gce | e132327 | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-e2e-gce-100-performance | 4036c2e | link | /test pull-kubernetes-e2e-gce-100-performance |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-device-plugin-gpu | d94e31e | link | /test pull-kubernetes-e2e-gce-device-plugin-gpu |
| pull-kubernetes-bazel-build | d94e31e | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce | d94e31e | link | /test pull-kubernetes-e2e-gce |
| pull-kubernetes-e2e-kops-aws | d94e31e | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-bazel-test | d94e31e | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-typecheck | d94e31e | link | /test pull-kubernetes-typecheck |
| pull-kubernetes-kubemark-e2e-gce | d94e31e | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-100-performance | d94e31e | link | /test pull-kubernetes-e2e-gce-100-performance |
| pull-kubernetes-integration | d94e31e | link | /test pull-kubernetes-integration |
| pull-kubernetes-kubemark-e2e-gce-big | d94e31e | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
| pull-kubernetes-verify | d94e31e | link | /test pull-kubernetes-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce | d94e31e | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-100-performance | d94e31e | link | /test pull-kubernetes-e2e-gce-100-performance |
| pull-kubernetes-e2e-kops-aws | b8dace6 | link | /test pull-kubernetes-e2e-kops-aws |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-100-performance | d94e31e | link | /test pull-kubernetes-e2e-gce-100-performance |
| pull-kubernetes-kubemark-e2e-gce-big | d94e31e | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-kops-aws | b8dace6 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-kubemark-e2e-gce | b8dace6 | link | /test pull-kubernetes-kubemark-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | d94e31e | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-kops-aws | b8dace6 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-kubemark-e2e-gce | b8dace6 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce | b8dace6 | link | /test pull-kubernetes-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@mikedanese: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Andrew Lytvynov
Ping @mikedanese can you rebase or close this?
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
k8s-ci-robot
Closed #63952.
k8s-ci-robot
@fejta-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—