Re: [kubernetes/kubernetes] Custom labels can't be added to PVC using StatefulSet.Spec.VolumeClaimTemplates (#58987)
k8s-ci-robot
@ateleshev: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-misc
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Artem Teleshev
/kind bug
krmayankk
/assign @krmayankk i can work on this
k8s-ci-robot
@krmayankk: GitHub didn't allow me to assign the following users: i, can, work, on, this.
Note that only kubernetes members and repo collaborators can be assigned.
In response to this:
/assign @krmayankk i can work on this
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Carsten
I stumbled upon this issue while making my first steps into k8s, volume claims and a custom controller. I tried to create a StatefulSet and wanted to use volumeClaimTemplates to create persistent volumes for my instances.
My controller would watch all volume claims for a specific label and then create cronjobs with custom commands on the volumes.
Here's my YAML for the StatefulSet
apiVersion: apps/v1 kind: StatefulSet metadata: name: myname namespace: mynamespace spec: serviceName: myname replicas: 2 selector: matchLabels: name: myname security-group: backend # we have to specify the cleanup label here, but then both volumeClaimTemplates get the keyword custom-label: "True" volumeClaimTemplates: - metadata: name: claim1 #labels: # custom-label: "True" spec: accessModes: ["ReadWriteMany"] resources: requests: storage: 1Gi - metadata: name: claim2 spec: accessModes: ["ReadWriteMany"] resources: requests: storage: 1Gi template: ...
If I understand this issue, I can not specify my custom-label for the first claim, but not for the second because currently the labels from the StatefulSet.Spec.Selector.MatchLabels are used exclusively. Is that correct?
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
k8s-ci-robot
Closed #58987.
Artem Teleshev
/reopen
k8s-ci-robot
Reopened #58987.
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
—
k8s-ci-robot
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
k8s-ci-robot
Closed #58987.
mohnishkodnani
/reopen
Kubernetes Prow Robot
@mohnishkodnani: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
krmayankk
/remove-lifecycle rotten
krmayankk
/reopen
Kubernetes Prow Robot
@krmayankk: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Kubernetes Prow Robot
Reopened #58987.
krmayankk
/sig apps
Xavier Lange
This would be fantastic. We would feel much better deleting PVCs based on labels!
mohnishkodnani
Please let me know if any help is needed on this.
Due to the inability to put labels, currently, in my use case i have to fetch all PVC's in the namespace and then manually filter out based on "annotations" because custom annotations are allowed.
But if labels are allowed, then in the ListOptions we can add a selector and make the query more efficient.
Alex Leonhardt
@krmayankk this would be great to get in, is there anything that needs doing / that's blocking this?
Artem Teleshev
It has already fixed in master branch
Artem Teleshev
/close
Kubernetes Prow Robot
@ateleshev: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Kubernetes Prow Robot
Closed #58987.
muvaffak
@ateleshev could you point to the related PR so that we can check which versions got it?
muvaffak
@ateleshev Thanks a lot!