Re: [kubernetes/enhancements] Snapshot / Restore Volume Support for Kubernetes (CRD + External Controller) (#177)

[Claire Laurence]

@jingxu97 Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Xing Yang]

Hi @claurence - we are working on "execution hook" and "PV/PVC taints and tolerations" for 1.14. Do we need KEP for those? If so, I'll submit a KEP for execution hook. Jing is working on a spec for taints and tolerations.

[Claire Laurence]

@xing-yang Thanks - all issues should have a KEP associated with them so please add one for this issue. Also do you have links to the PRs for the two items referenced above?

[Claire Laurence]

Also is alpha still the correct stage or is this feature graduating to beta?

[Xing Yang]

@claurence Yes, it is still Alpha.
We are still working on the KEP so it is not submitted yet. What is the deadline for submitting a KEP?

[Xing Yang]

@claurence here's the KEP on ExecutionHook: #705

[Claire Laurence]

@xing-yang please submit the KEP before the enhancements freeze date for Jan 29th

[Kendrick Coleman]

Hello @xing-yang, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. This will also require a KEP to be included.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

[Xing Yang]

Hi @kacole2 , the snapshot feature tracked by this issue will remain as alpha. I'm going to create another enhancement issue to track the ExecutionHook feature separately.

[Xing Yang]

Hi @kacole2 , enhancement issue is created for ExecutionHook here: #962

[Michelle Au]

We are targeting beta for 1.16

[Kendrick Coleman]

/stage beta
/milestone v1.16

@msau42 this is still missing a KEP. I'll put it in the tracking sheet for now.

[Michelle Au]

@xing-yang can you look into creating a kep for this? I'm not sure how up-to-date the original design doc was, but we can point to it from the kep

[Xing Yang]

@msau42 @kacole2 Here is the original design doc that was already merged. https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-snapshot.md

Do I need to create a KEP and point to this doc?

[Michelle Au]

Yes, all enhancements should go through keps now. If the original design doc is mostly up-to-date, then you can just create a kep that points to it. Take a look at the template and see if the kep sections are already included in the design doc or not (namely graduation criteria, test plan, implementation history, etc). Here's an example of a storage kep that points to the original design doc and adds missing sections: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190124-csi-topology.md

[Xing Yang]

KEP submitted: #1133

[simplytunde]

Hey, @jingxu97 @xing-yang I'm the v1.16 docs release lead.

Does this enhancement (or the work planned for v1.16) require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[Xing Yang]

Hi @simplytunde, we need to modify a few places in the docs to change from v1alpha1 to v1beta1 and also indicates the feature gate change. Will submit a doc PR soon. Thanks.

[Kendrick Coleman]

@xing-yang @jingxu97
Enhancement freeze is EOD 7/30. This issue still requires a merged KEP to be considered a part of the release. This is being labeled as At Risk and will be dropped from the milestone if it's not merged tomorrow. Thanks.

[Xing Yang]

In-tree PR is submitted here: kubernetes/kubernetes#80058.
Out-of-tree PR is submitted here: kubernetes-csi/external-snapshotter#139

[Xing Yang]

Doc PR submitted: kubernetes/website#15942

[Kendrick Coleman]

@xing-yang friendly reminder that Thursday 8/29 is k/k code freeze for getting kubernetes/kubernetes#80058 merged

[Xing Yang]

Thanks @kacole2 for the reminder! We are working on it.

[Xing Yang]

@kacole2 We couldn't get code merged today. This will be delayed to 1.17.

[Bob Killen]

Hey there @xing-yang @jingxu97 -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.17?

The current release schedule is:

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[Xing Yang]

Hi @mrbobbytables Yes, we are planning to bring this feature to Beta in 1.17.

[Bob Killen]

Awesome, thank you! I'll go ahead and add it to the tracking sheet :)

[Irvi Aini]

Hello @xing-yang @jingxu97 I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

—
You are receiving this because you are on a team that was mentioned.

Reply to this email directly, view it on GitHub, or unsubscribe.

[Xing Yang]

Thanks @irvifa ! I'll submit a doc soon.

[Xing Yang]

@irvifa Doc PR is submitted here: kubernetes/website#17233

[Jeremy Rickard]

Hey there @xing-yang. I'm one of the enhancements shadows for the 1.17 release. Code Freeze is rapidly approaching on November 14th, so I wanted to touch base and see how this was going. Could you also please link to any k/k PRs that are being worked on as part of this issue? We don't have anything tracked in the enhancements spreadsheet.

Thanks so much!

[Xing Yang]

Hi @jeremyrickard, here are the PRs:

• [Merged] Move snapshot APIs to Beta: kubernetes-csi/external-snapshotter#139
• [Merged] Update external-provisioner to use the new snapshot beta API: kubernetes-csi/external-provisioner#335
• Snapshot controller split PR: kubernetes-csi/external-snapshotter#178
• Updated snapshot in-tree e2e tests using snapshot Beta APIs and enable feature gate: kubernetes/kubernetes#80058
• Doc PR: kubernetes/website#17233

[Jeremy Rickard]

Thanks so much @xing-yang! I'll get the spreadsheet updated.

[Xing Yang]

Two more PRs got merged. Here is the new status:

• [Merged] Move snapshot APIs to Beta: kubernetes-csi/external-snapshotter#139
• [Merged] Update external-provisioner to use the new snapshot beta API: kubernetes-csi/external-provisioner#335

• [Merged] Snapshot controller split PR: kubernetes-csi/external-snapshotter#178
• [Merged] Updated snapshot in-tree e2e tests using snapshot Beta APIs and enable feature gate: kubernetes/kubernetes#80058
• [Review in progress] Doc PR: kubernetes/website#17233

So we've made the Code Freeze date. The only required PR outstanding is the Doc PR which is being reviewed.

[Xing Yang]

Doc PR kubernetes/website#17233 is also merged.

[Jeremy Rickard]

Hey there @xing-yang @jingxu97 -- 1.18 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.18?

The current release schedule is:

Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

—

[Xing Yang]

Hi @jeremyrickard, this feature will stay at Beta in 1.18. Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[Nabarun Pal]

/remove-lifecycle stale

[Mirek Sedzinski]

Hey there @jingxu97 -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released
• Thursday, August 20: Week 19 - Release Retrospective

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

—

[Xing Yang]

Hi @msedzins, we plan to stay beta in 1.19. Thanks!

[Mirek Sedzinski]

Hi @xing-yang,

Thank you for the update!

[Mirek Sedzinski]

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

—

[Xing Yang]

/remove-lifecycle stale

[Xing Yang]

We are planning to bring this feature to GA in 1.20.

[Xing Yang]

Hi @kikisdeliveryservice,

Can you please add this to the v1.20 tracking sheet? Thanks!

[Kirsten]

Done 👍 Thanks for the update.

[Kirsten]

Hi @xing-yang

Looks like your PR is complete and ready to merge: #1994 (comment)

You just need to remove the hold so it can merge by Freeze on October 6th

😄

[Xing Yang]

Hi @kikisdeliveryservice,

I just need Michelle to review and LGTM:).

Thanks!

[Kirsten]

Hey @xing-yang !

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks! 😸
Kirsten

[Xing Yang]

Hi @kikisdeliveryservice,

Thanks for the reminder!

Here is the k/k PR:
kubernetes/kubernetes#95282

Xing

[Leslie-Alexandre DENIS]

Hello @xing-yang @jingxu97 👋, 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo.

This PR can be just a placeholder at this time and must be created before Nov 6th
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[Xing Yang]

Thanks @eagleusb ! I'll submit a placeholder doc soon.

[Leslie-Alexandre DENIS]

Hi @xing-yang 👋

Thanks for your update. In the meantime, the docs placeholder deadline is almost here.

Please make sure to create a placeholder PR against the dev-1.20 branch in the k/website before the deadline.

Also, please keep in mind the important upcoming dates:

• Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
• Thursday, Nov 12th: Week 9 - Code Freeze

• Monday, Nov 23rd: Week 11 - Docs PR Ready for ReviewAs a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

[Xing Yang]

Hi @eagleusb ,

Thanks for the reminder! Doc PR is submitted here: kubernetes/website#24849

[Kirsten]

Hi @xing-yang

Looks like kubernetes/kubernetes#95282 is still open but being actively worked on. Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Best,
Kirsten

[Xing Yang]

Hi @kikisdeliveryservice ,

Thanks for the reminder! We are trying to get reviewers to finish reviewing and approving the PR by the 11/12 deadline.

Xing

[Xing Yang]

This PR is merged: kubernetes/kubernetes#96383
We are moving closer.

[Kirsten]

Great! just waiting on kubernetes/kubernetes#95282

[Xing Yang]

@kikisdeliveryservice ,

kubernetes/kubernetes#95282 is approved. Just waiting for it to be merged:).

[Kirsten]

Yay! It's merged! Updating tracking sheet.

Congrats! 🎆

[Xing Yang]

Thanks @kikisdeliveryservice!

[Kirsten]

Hi @xing-yang

Can you update the kep.yaml to reflect a status of implemented: https://github.com/kubernetes/enhancements/blob/f40c24a5da09390bd521be535b38a4dbab09380c/keps/sig-storage/177-volume-snapshot/kep.yaml#L10

Once that merges we can then close this issue.

Thanks!
Kirsten

[Xing Yang]

Hi @kikisdeliveryservice,

Will submit a PR soon. Thanks!

Xing

[Kirsten]

Thanks @xing-yang it's merged! Feel free to close this issue 😄

[Anna]

Hello, 1.21 Enhancement lead here.
I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

[Kubernetes Prow Robot]

@annajung: Closing this issue.

In response to this:

Hello, 1.21 Enhancement lead here.
I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Kubernetes Prow Robot]

Closed #177.

[Mickey Boxell]

Hi @jingxu97 👋 1.24 RT Comms lead here. I saw a note that the VolumeSnapshot v1beta1 CRD will be removed in 1.24. Would this be appropriate to include in our 1.24 Removals and Deprecations blog post?

—

Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1068683801@github.com>

[Jing Xu]

Yes, I think so

@xing-yang

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1068698215@github.com>

[Mickey Boxell]

Thanks for confirming! @jingxu97 What information would you like communicated in the blog? I read that the functionality entered beta in 1.20 and was a little confused about the v1beta1 CRD now being removed. Did the project graduate to stable or was it replaced with an alternative API?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1068739211@github.com>

[Jing Xu]

VolumeSnapshot went GA in 1.20
#1994

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1068757796@github.com>

[Xing Yang]

@mickeyboxell I added that entry in the spreadsheet. VolumeSnapshot went GA in 1.20. Following K8s 1.21 release, we deprecated VolumeSnapshot v1beta1. Since VolumeSnapshot is out-of-tree CRD, we have the deprecation message in the release note here:
https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v4.1.0

Now we are ready to remove VolumeSnapshot v1beta1 CRD in our next external-snapshotter release which will be v6.0, shortly after K8s 1.24 release.

We want to add a message in the deprecation/removal blog to indicate that VolumeSnapshot v1beta1 CRD will be removed in K8s 1.24.

Hope this helps.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1069109508@github.com>

[Xing Yang]

@mickeyboxell In addition to the deprecation/removal blog, I'd also like to have a release note in K8s v1.24 release notes to indicate VolumeSnapshot v1beta1 CRD will be removed. Where can I add that release note?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1069113085@github.com>

[Mickey Boxell]

I'm not sure how their process works. You may want to reach out to the #release-notes channel for more information.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/enhancements/issues/177/1074568300@github.com>