Re: [kubernetes/kubernetes] Kubelet: fix the runonce feature to support volumes and avoid panic (#56987)
Yu-Ju Hong
- @kubernetes/sig-storage-feature-requests for any concerns/suggestions about supporting volumes in the run-once mode
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Clayton Coleman
It looks like run-once is broken in systemd mode in general - without starting the container runtime you can't get cgroups, which causes a failure during syncpod
Even though we're considering deprecation, it's worth taking a brief look at whether this is an adequate fix for the intermediate term.
Clayton Coleman
rob boll
Any chance of this making it into 1.10?
Jan Šafránek
/sig node
@kubernetes/sig-node-pr-reviews
Julien Balestra
@derekwaynecarr @saad-ali any chance to have a review soon ?
Seth Jennings
/lgtm
k8s-ci-robot
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JulienBalestra, sjenning
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: derekwaynecarr
Assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Julien Balestra
/remove-lifecycle stale
steven
We need runonce to init etcd cluster as static pod, then using kubeadm to init master.
steven
Davanum Srinivas
@derekwaynecarr @saad-ali can you please take a look at this?
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
—
Julien Balestra
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Julien Balestra
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Kubernetes Prow Robot
Closed #56987.
Kubernetes Prow Robot
@fejta-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.