Re: [kubernetes/kubernetes] StatefulSet: update forbidden because of PVC storage units (#66137)

4 views
Skip to first unread message

k8s-ci-robot

unread,
Jul 12, 2018, 4:25:03 PM7/12/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

@derekperkins: Reiterating the mentions to trigger a notification:
@kubernetes/sig-storage-bugs

In response to this:

@kubernetes/sig-storage-bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Michelle Au

unread,
Jul 12, 2018, 4:34:52 PM7/12/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

cc @k8s-mirror-api-machinery-bugs

This is probably an issue for any resource.Quantity type.

krmayankk

unread,
Jul 13, 2018, 2:14:33 AM7/13/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

/sig api-machinery

Jordan Liggitt

unread,
Jul 13, 2018, 1:27:51 PM7/13/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

the issue is use of !reflect.DeepEqual in statefulset update validation, instead of apiequality.Semantic.DeepEqual, which explicitly compares quantity objects semantically:

https://github.com/kubernetes/kubernetes/blob/c174e4121fa3cacaf9c2f762446517a03997411e/staging/src/k8s.io/apimachinery/pkg/api/equality/semantic.go#L29-L36

Jordan Liggitt

unread,
Jul 13, 2018, 1:27:57 PM7/13/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

/sig apps

Jordan Liggitt

unread,
Jul 13, 2018, 1:53:22 PM7/13/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

fix is in #66165 with picks open to 1.11, 1.10, 1.9

Kubernetes Submit Queue

unread,
Jul 17, 2018, 3:17:07 AM7/17/18
to kubernetes/kubernetes, k8s-mirror-storage-bugs, Team mention

Closed #66137 via #66165.

Reply all
Reply to author
Forward
0 new messages