Exception Request: Pass cluster information to exec credential providers

14 views
Skip to first unread message

Andrew Keesler

unread,
Oct 8, 2020, 3:16:49 PM10/8/20
to kubernete...@googlegroups.com, kubernetes-...@googlegroups.com, releas...@kubernetes.io

Hi Release Team -

 

Enhancement name: Pass cluster information to exec credential providers

Enhancement status (alpha/beta/stable): Beta

SIG: Auth

k/enhancements repo issue #: https://github.com/kubernetes/enhancements/issues/541

PR #’s: https://github.com/kubernetes/enhancements/pull/2023

Additional time needed (in days): 1

Reason this enhancement is critical for this milestone: it would be an important step towards removing cloud credential providers from in-tree :)

Risks from adding code late: none 

Risks from cutting enhancement: none

 

I didn’t know the best way to communicate this above, but this exception request would be just for tying off the couple of questions left on https://github.com/kubernetes/enhancements/pull/2023, so that we could finish implementing https://github.com/kubernetes/kubernetes/pull/91192.

 

Thanks for your time and consideration.

 

Jeremy Rickard

unread,
Oct 12, 2020, 12:21:41 PM10/12/20
to Andrew Keesler, kubernete...@googlegroups.com, kubernetes-...@googlegroups.com, releas...@kubernetes.io
Hi Andrew,

Thank you for opening this exception request, I apologize for the delay in my response.

We had not been tracking this toward Enhancement Freeze and needed to do a little digging to see what work would be outstanding to get this into the proper state. We will conditionally approve this request, with the following conditions:

* The kep.yaml needs to be updated to reflect the milestone and stage. There have been some changes to the kep.yaml file and this one has not been updated to reflect. You can find an example here: https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/kep.yaml. Specifically, please add the stage + latest milestone + milestones (to reflect history)
* Update the KEP to fill out as much of the PRR questionare as possible https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template#production-readiness-review-questionnaire

I see that your PR updating the design merged already, so we'd ask that you please open another PR to address the issues above and work to get it merged ASAP this week.

Also, please keep in mind the upcoming dates for the release:

Thursday, Nov 12th - Code Freeze
Monday, Nov 23rd - Test Freeze
Monday, Nov 30th - Docs must be completed and reviewed

Thank you!

--
To unsubscribe from this group and stop receiving emails from it, send an email to release-team...@kubernetes.io.
Reply all
Reply to author
Forward
0 new messages