Re: Exception request for MatchConditions

21 views
Skip to first unread message

Xander Grzywinski

unread,
Mar 14, 2023, 7:46:27 PM3/14/23
to release-team, Tim Allclair, Max Smythe, igor.veli...@gmail.com, Jordan Liggitt, kubernetes-sig...@googlegroups.com, kubernetes-...@googlegroups.com
Hi all,

Following discussion in K8s Slack the release team is APPROVING this exception request. Your updated deadline to make any changes to your PR is 17:00 PDT Thursday 16th March 2022.

If you have any questions, please reach out to us in the #sig-release Slack channel.

Thanks,
Xander Grzywinski,
1.27 Release Team Lead

On Tuesday, March 14, 2023 at 4:18:17 PM UTC-7 Tim Allclair wrote:
We are requesting an exception to the MatchConditions implementation, which is used across 2 features (AdmissionWebhookMatchConditions and CELValidatingAdmission). These are both very close to being done, but we are filing a preemptive exception request. The review work to get these merged is minimal at this point.

  • Enhancement name: AdmissionWebhookMatchConditions, CELValidatingAdmission
  • Enhancement status (alpha/beta/stable): alpha
  • SIG: api-machinery
  • k/enhancements repo issue #: 3716, 3488
  • PR #’s:
  • Additional time needed (in days): 2 (conservative)
  • Reason this enhancement is critical for this milestone: these are important enhancements to make webhooks more usable, and unblocking subsequent beta graduation
  • Risks from adding code late: (to k8s stability, testing, etc.) - Most refactoring has already landed, but there is some restructuring to admission webhook code that is not guarded by feature flags. Integration tests have been added to enhance coverage in this area.
  • Risks from cutting enhancement: (partial implementation, critical customer use case, etc.)
    • Webhooks continue to be a major source of operational pain
    • ValidatingAdmissionPolicy is graduation is delayed

Tim Allclair

unread,
Mar 14, 2023, 10:23:03 PM3/14/23
to kubernetes-sig...@googlegroups.com, releas...@kubernetes.io, kubernetes-...@googlegroups.com, Max Smythe, igor.veli...@gmail.com, Jordan Liggitt

Jordan Liggitt

unread,
Mar 16, 2023, 9:33:00 AM3/16/23
to kubernetes-sig-release
Following up, the exception was granted, both PRs are now merged and the feature is code-complete for 1.27.
Reply all
Reply to author
Forward
0 new messages