Code freeze extension request for KEP-1287: In-place pod resize

356 views
Skip to first unread message

Tim Allclair

unread,
Nov 7, 2024, 5:52:04 PM11/7/24
to kubernetes-sig-node, releas...@kubernetes.io, kubernetes-...@googlegroups.com, Dawn Chen
Enhancement name: InPlacePodVerticalScaling / In-place pod resize
Enhancement status: graduating to beta
SIG: Node
k/enhancements repo issue: https://github.com/kubernetes/enhancements/issues/1287

PR #’s:

waiting to merge:

have lgtm, awaiting approval:

In review:
https://github.com/kubernetes/kubernetes/pull/127184 (I might open a new PR for this)

Additional time needed (in days):
5 days (2 american business days)
Reason this enhancement is critical for this milestone: This feature has been in alpha for a long time, and is growing in priority due to the changing nature of Kubernetes workloads.
Risks from adding code late: These changes are non-trivial, but most of the large changes are already merged. The sidecar PR is the biggest remaining change, but that is fairly straightforward. 
The risk to merging these late is reduced stabilization and testing time, but I will be focused on manual testing of this feature over the remaining stabilization period.
Risks from cutting enhancement: In addition to this feature being increasingly important for lots of customers, there are also a number of features that might land in v1.33 which will complicate in-place resize. It would be better to land beta in v1.32, so we can strictly focus on the net-new features in v1.33 (e.g. pod level resources)

Dawn Chen

unread,
Nov 7, 2024, 6:46:18 PM11/7/24
to Tim Allclair, kubernetes-sig-node, releas...@kubernetes.io, kubernetes-...@googlegroups.com
Tim, and I went over together one-by-one this morning, I agreed with him from the SIG Node perspective, especially since we have a risk mitigation plan too. 

Tim Allclair

unread,
Nov 7, 2024, 10:48:32 PM11/7/24
to Dawn Chen, kubernetes-sig-node, releas...@kubernetes.io, kubernetes-...@googlegroups.com
A lot of work went in today, so this request deserves an update. There are just 3 PRs that really need the extension, with another 3 already approved:

3 PRs are approved and waiting to merge

2 PRs still need some work:

The final PR is just the gate flip: https://github.com/kubernetes/kubernetes/pull/128682


I think we still need the 5 day extension to get the sidecars support merged, although it's possible we'll finish tomorrow.

--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-node" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/kubernetes-sig-node/CAJo%3DGk6xsoeUtrXDUdCVvPxgTP2bmdqdsd530%2B5%3D%2BTHuOkT83w%40mail.gmail.com.

Sotiris Salloumis

unread,
Nov 9, 2024, 3:58:39 PM11/9/24
to kubernetes-sig-node
Thanks for your hard work Tim and other contributors the last three weeks, +1 great work.
Message has been deleted

Anoop Gopalakrishnan

unread,
Nov 11, 2024, 1:48:21 PM11/11/24
to kubernetes-sig-node
Thanks to Tim, Vinay and the community!!! This is great progress and will be of immense use to some companies reducing their cloud cost and also our climate cost. Hope to see this becoming beta in 1.32 and  being uptaken in the VPA in upcoming releases. 
Reply all
Reply to author
Forward
0 new messages