Re: [kubernetes/kubernetes] Unable to delete stale objects with `kubectl apply --prune` when no object passed in. (#40635)
Zihong Zheng
cc @ymqytw @kubernetes/sig-cli-misc
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Mengqi Yu
Original discussion in PR #33075
caleb miles
Is there someone from @kubernetes/sig-cli-bugs that can help triage this issue and own it? Thanks!
cc: @mikedanese, @errordeveloper, @lukemarsden
Mengqi Yu
cc: @pwittrock @liggitt
What is the expected behavior?
Should we delete all the resources that matching the labels, even though 0 files passed in (with -f) match the labels?
Jordan Liggitt
apply --prune globally searches for all existing resources and deletes them if they don't exist in the referenced files? that seems really easy to fat-finger a huge deletion.
Zihong Zheng
I think a sane semantic may be "delete objects that don't exist in this path, but were created by the same user before using kubectl apply in the same path".
Jordan Liggitt
the creating user is not stored in the API, so that data is not available to make decisions based on. I'm not sure what you mean by "in the same path"
Zihong Zheng
Yeah that data is not available on apiserver. By "in the same path" I mean this user is manipulating the same set of files --- objects created by kubectl apply -f /objects/folder will only be pruned by kubectl apply -f /objects/folder --prune if the referenced files are deleted, but not by kubectl apply -f /other/folder --prune.
BTW #33075/comment maybe relevant.
Mengqi Yu
@calebamiles We are not going to fix this in 1.6. We will do that in 1.7
cc: @pwittrock
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
James Wen
Bumping that this issue is one we're interested in. Use case is in #57916
Ilya Dmitrichenko
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
George Kraft
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
George Kraft
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Joost Cassee
/remove-lifecycle stale
Ijaz ahmad
Same issue , k8s version 1.12 , client 1.13
the resources matching the label are still there and prune doesnt work.
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
—
Joost Cassee
/remove-lifecycle stale
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Kubernetes Prow Robot
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Kubernetes Prow Robot
Closed #40635.
Jacob Henner
/reopen /remove-lifecycle rotten