Re: [kubernetes/kubernetes] kubectl diff command (#6284)
Filip Grzadkowski
@kubernetes/sig-cli-feature-requests
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Shiyang Wang
I'm work on a new command kubectl apply diff-last-applied here #46560, I think part of the code could be reuse, if there any one already taken this yet ? if not, I would like to do that
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale
Janet Kuo
Closed #6284.
Janet Kuo
kubectl diff has been implemented as an alpha release in 1.9. Feature tracking issue: kubernetes/features#491
Gustavo J. A. M. Carneiro
There is no documentation about what the exit status of the command means.
It seem that the exit status is 0 if there are no changes and 1 if there are changes. But without explicit documentation I am afraid to rely on this documented behaviour and it breaking in the future.
Chris Rust
@gjcarneiro I agree that this behavior should be documented (and tested if it isn't already), but I'd like to point out that this is how the linux diff cli tool works as well and I imagine this was implemented this way purposefully and is likely safe to rely upon.
Antoine Pelisse
@gjcarneiro I agree that this behavior should be documented (and tested if it isn't already), but I'd like to point out that this is how the linux diff cli tool works as well and I imagine this was implemented this way purposefully and is likely safe to rely upon.
Correct, but we still should document that none-the-less. Thanks for the interest.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Mark Janssen
kubernetes/kubectl#707 was created to improve the exit code behaviour, hopefully this will result in some documentation as well.
Antoine Pelisse
/wg apply