Re: Exception request for ClusterTrustBundles (Alpha, feature-gated)

136 views
Skip to first unread message

Taahir Ahmed

unread,
Mar 16, 2023, 12:45:39 PM3/16/23
to kubernetes-...@googlegroups.com, kubernete...@googlegroups.com, releas...@kubernetes.io, Jordan Liggitt
Oops, missed that this also needed to go to a few other addresses.

On Thu, Mar 16, 2023 at 9:30 AM Taahir Ahmed <ta...@google.com> wrote:
To clarify, PR 113218 is fully separable from 113374.  Both have their own feature gates.

On Thu, Mar 16, 2023 at 9:26 AM Taahir Ahmed <ta...@google.com> wrote:
Hi all,

I'd like to request an exception for the ClusterTrustBundles PR.  This is an Alpha feature, locked behind a feature gate.  The PR was ready to go at the deadline, but missed due to needing to rebase and re-LGTM multiple times during the churn as the release window closed.

  • Enhancement Name: ClusterTrustBundles
  • Enhancement Status: Alpha
  • SIG: auth
  • k/enhancements repo issue: 3257
  • PR: 113218
  • Additional time needed: 1 day or less.
  • Reason this enhancement is critical for this milestone: This PR has already slipped one release due to review bandwidth constraints.  Having ClusterTrustBundles available in-tree will simplify the prototyping and development of follow-on features, including ClusterTrustBundle projected volumes and Workload Certificate projected volumes.
  • Risks from adding code late:  Minimal.  This is an alpha feature with a dedicated feature gate.  It is not on by default, or even if a cluster enables Alpha APIs.
  • Risks from cutting enhancement: Also minimal, but changes that are ready to go and have all required LGTMs at the freeze should be allowed to merge.
Taahir

David Eads

unread,
Mar 16, 2023, 1:02:23 PM3/16/23
to Taahir Ahmed, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com, releas...@kubernetes.io, Jordan Liggitt
I'm in favor of granting the exception.

--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-auth" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-auth/CAC%3DMKY_perV00dwOyLzP07rV1PQZxDix-VmgrA9f0x6aETaM_w%40mail.gmail.com.

Jordan Liggitt

unread,
Mar 16, 2023, 1:12:07 PM3/16/23
to David Eads, Taahir Ahmed, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com, releas...@kubernetes.io
I'm also in favor. https://github.com/kubernetes/kubernetes/pull/113218 is reviewed/approved/green and just needs an unhold.

Mo Khan

unread,
Mar 16, 2023, 1:17:02 PM3/16/23
to Jordan Liggitt, David Eads, Taahir Ahmed, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com, releas...@kubernetes.io
Reply all
Reply to author
Forward
0 new messages