Exception request for KEP-3329 'Retriable and non-retriable Pod failures for Jobs'

9 views
Skip to first unread message

Michał Woźniak

unread,
Nov 4, 2022, 1:24:04 PM11/4/22
to kubernete...@googlegroups.com, releas...@kubernetes.io, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com
Hi,

Please review the exception request below. 
There are two remaining PRs: 112360 extends the feature, 113360 promotes the feature into Beta. The review of 112360 is in-progress with most of the remarks applied, no major concerns raised. The 113360 PR is LGTMed, but it depends on the 112360 PR so will need to be rebased, but no essential changes will be required.

Enhancement name: Retriable and non-retriable Pod failures for Jobs
Enhancement status (alpha/beta/stable): Beta
SIG: sig-apps (sig-node participating)
k/enhancements repo issue #: 3329
PR #’s: 112360, 113360
Additional time needed (in days): 5
Reason this enhancement is critical for this milestone: To keep the functionality on track for GA
Risks from adding code late: (to k8s stability, testing, etc.) Most of the new code is behind the “PodDisruptionConditions” feature gate which limits the risk. The 112360 PR includes unit, integration and node e2e tests providing nearly 100% coverage for the new code. The 113360 PR graduates the feature into Beta, but includes e2e tests for the core functionality to lower the risk.
Risks from cutting enhancement: (partial implementation, critical customer usecase, etc.): Delayed adoption of the feature in OSS to support use-cases around avoiding unnecessary costs for running batch workloads. Criticality is unknown.

Regards.
Michał

Aldo Culquicondor

unread,
Nov 4, 2022, 2:16:41 PM11/4/22
to Michał Woźniak, kubernete...@googlegroups.com, releas...@kubernetes.io, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com
I would clarify that this feature is rather critical, as users incur in unnecessary retries, which translate to cost.

Aldo


--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-apps" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-apps/CAPLTvwemMSYJiCDv-yr-VEBjCZQSL5YLaL3pt-vKNxpZFJdZQw%40mail.gmail.com.

Leonard Pahlke

unread,
Nov 8, 2022, 4:52:28 AM11/8/22
to release-team, Aldo Culquicondor, kubernete...@googlegroups.com, releas...@kubernetes.io, kubernetes-...@googlegroups.com, kubernete...@googlegroups.com, Michał Woźniak
Hi all,

Following discussion in K8s Slack the release team is APPROVING this exception request. Your updated deadline to make any changes to your PR/KEP is 18:00 PST Friday 11th November 2022, which is four working days from today.

If you have any questions, please reach out to us in the #sig-release Slack channel.

Thanks,
Leonard Pahlke,
1.26 Release Team Lead
Reply all
Reply to author
Forward
0 new messages