v1.20 release code freeze exception: API priority and fairness

[Adhityaa Chandrasekar]

Hi there,

I'm @adtac on Github and I'd like to request the following code freeze exception on behalf of sig/api-machinery and the people CC'd in this email.

• Enhancement name: API Priority and Fairness
  
• Enhancement status (alpha/beta/stable): alpha to beta
  
• SIG: api-machinery
  
• k/enhancements repo issue #: https://github.com/kubernetes/enhancements/issues/1040
• PR #’s: https://github.com/kubernetes/kubernetes/pull/96527
• Additional time needed (in days): 2 days
  
• Reason this enhancement is critical for this milestone: APF introduces several improvements to how the API server handles traffic.
  
• Risks from adding code late: (to k8s stability, testing, etc.) We've been working on testing for a while now, so we don't expect any issues stemming from adding code late. Besides, it's likely just a matter of a few hours past the deadline. We also plan to keep adding tests till the tests freeze deadline.
  
• Risks from cutting enhancement: Putting on my sig-scheduling hat on, the scheduling team was really looking forward to this enhancement. We've made significant strides in improving the performance of the k8s scheduler, but we cannot realise those gains until API priority and fairness is merged. Also, we've invested significantly into automating APF-related scalability testing (and plan to continue to do so); none of this can be realised until APF is actually merged. I'm sure Mike, Min, Daniel, and/or David (all CC'd in this email) can add to this.

I believe @kikisdeliveryservice on Github can vouch for how close we were to getting it merged within the deadline. (Unfortunately, I don't have their email to CC.)

Thanks,

Adhityaa

[Jeremy Rickard]

Hi Adhityaa,

Thank you for submitting this exception request. Based on the size of this PR and the ongoing discussions, as well as the impact it has on calls to the API Server, we feel that this introduces a little too much risk for the 1.20 release and feel that this would be better to land in the 1.21 release. With that context, we will be DENYING this exception request. If you feel that this requires more conversation and evidence, please contact us in #sig-release.

Thanks,

Jeremy Rickard // 1.20 Release Lead

--
To unsubscribe from this group and stop receiving emails from it, send an email to release-team...@kubernetes.io.

[Daniel Smith]

Update on this-- with some more discussion, Jeremy & the release team very graciously merged this provisionally, we had a rollback PR ready to go if it broke things. But everything looks fine. Thanks!

And extra thanks to Adhityaa, who did the hard work!

And for the curious--the difficulty was the integration tests breaking what we believed to be an invariant (that every user is either authenticated or unauthenticated).