Re: [kubernetes/kubernetes] [upgrade test failure] Initializers should be invisible to controllers by default (#52585)

[Kubernetes Submit Queue]

[MILESTONENOTIFIER] Milestone Labels Complete

@ericchiang

Issue label settings:

• sig/api-machinery: Issue will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Additional instructions available here The commands available for adding these labels are documented here

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Eric Chiang]

cc @kubernetes/sig-api-machinery-test-failures
cc @kubernetes/kubernetes-release-managers
/kind bug
/king upgrade-test-failure

Observed on the upgrade cluster test suite

https://k8s-testgrid.appspot.com/master-upgrade#gce-1.7-master-upgrade-cluster-parallel

Example failure

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-new-master-upgrade-cluster-parallel/568

/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/extension/initializers.go:108
Expected error:
    <*errors.StatusError | 0xc4202f7680>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {SelfLink: "", ResourceVersion: ""},
            Status: "Failure",
            Message: "Pod \"uninitialized-pod\" is invalid: metadata.initializers.pending[0].name: Invalid value: \"Test\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')",
            Reason: "Invalid",
            Details: {
                Name: "uninitialized-pod",
                Group: "",
                Kind: "Pod",
                UID: "",
                Causes: [
                    {
                        Type: "FieldValueInvalid",
                        Message: "Invalid value: \"Test\": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')",
                        Field: "metadata.initializers.pending[0].name",
                    },
                ],
                RetryAfterSeconds: 0,
            },
            Code: 422,
        },
    }
    Pod "uninitialized-pod" is invalid: metadata.initializers.pending[0].name: Invalid value: "Test": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
not to have occurred
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/extension/initializers.go:54
				

[Jordan Liggitt]

Initializer name validation tightened in 1.8 (and is release noted as needing action), test should be updated with a valid name

[Jordan Liggitt]

should be fixed by #52592

[Eric Chiang]

Fix merged into 1.7 branch. Closing.

[Eric Chiang]

Closed #52585.