Re: [kubernetes/kubernetes] Event recorder should enfoce API conventions for Event Reason (#14111)
Michail Kargakis
@kubernetes/sig-api-machinery-misc
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
Brian Grant
cc @gmarek
Marek Grabowski
/remove-lifecycle state
/lifecycle frozen
Marek Grabowski
@yastij - I wrote a bunch of validation logic for Events v2 in the initial PR, but it may be worth revisiting to check if all fields are properly validated, according to kubernetes/community#1659.
Yassine TIJANI
@gmarek - I'll take a look
Nikhita Raghunath
/remove-lifecycle stale
Tim Bannister
Strengthening validation would be a breaking API change. As much as I'd like to enforce the conventions, this can't be the way to do it. Or maybe the check could be enabled only during tests.
Could we write a code validator instead?
It is also true that it seems hard to make the check stronger than just capitalization, but not capitalizing the first letter is one of the most common inconsistencies.
We now have warnings and a framework for instrumentation, so maybe there's something we can revisit here.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.