[kubernetes/kubernetes] client-go needs backwards compatibility test (#133553)

[Chao Xu]

caesarxuchao created an issue (kubernetes/kubernetes#133553)

Client-go needs backwards compatibility test, i.e, checking if a PR changes the public interfaces of client-go. The benefits are:

• Ensuring release-note is added if a PR has backwards incompatible changes.
• Making breaking changes more obvious, so developers can avoid them if possible.
• Helping determine if the major version of client-go needs to be bumped when we cut a release.

The backwards compatibility test is useful no matter if we develop client-go in the kubernetes repo or in this repo.

Special requirements:

• Need to check backwards compatibility of the underlying k8s.io repos, including k8s.io/apimachinery and k8s.io/api, because client-go user deals with their interfaces as well.

Action items:

• find existing tool that looks for breaking changes.
• alternatively write a tool using go2idl.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/kubernetes/issues/133553@github.com>

[Jordan Liggitt]

liggitt left a comment (kubernetes/kubernetes#133553)

We run api-diff now.

+1

/close

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/kubernetes/issues/133553/3191347302@github.com>

[Kubernetes Prow Robot]

Closed #133553 as completed.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are on a team that was mentioned.Message ID: <kubernetes/kubernetes/issue/133553/issue_event/19175206856@github.com>