Re: [kubernetes/kubernetes] apimachinery - Support for Float comparisons in selector.go for Gt Lt operations (#44932)
Nikhil Jindal
cc @kubernetes/sig-api-machinery-misc @davidopp
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Daniel Smith
I think supporting float comparison is a reasonable feature request.
But are you sure you don't want support for semver? That seems more useful for versions?
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
Carolyn Van Slyck
I hope it's okay to unmark this as stale?
/remove-lifecycle stale
I'd like to be able to filter using comparison operators such as greater than and less than for Service Catalog. Semver would be amazing but standard comparisons have a lot of value as well. I am interested in trying to flesh this out further, maybe do an implementation.
Dr. Stefan Schimanski
/lifecycle frozen
Carolyn Van Slyck
@sttts Thanks! ❤️ I am still learning how to talk to the ci robot.
PRANAV PANDEY
This sounds like a valuable enhancement, could you elaborate on additional scenarios where this feature could be leveraged?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
PRANAV PANDEY
In addition to basic float comparisons, @lavalamp mentioned the potential for supporting semantic versioning.
This could indeed be more applicable for handling versions. Do we have a consensus on whether implementing semver directly might address the needs more effectively than simple float comparisons, or should both options be considered?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
PRANAV PANDEY
@carolynvs, it's great to see your interest in moving this forward! If we decide to proceed with implementing either float comparisons or semver, I would be interested in contributing to the development or documentation.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
PRANAV PANDEY
Has there been any preliminary work or a draft proposal on how we might implement this in the selector logic?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.