[kubernetes/kubernetes] Use `cmp.Equal` instead of DeepEqual? (#55722)

[Tim Hockin]

https://github.com/google/go-cmp/

I wonder if this can replace our semantic DeepEqual?

@lavalamp
@kubernetes/sig-api-machinery-bugs

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[Tim Hockin]

/lifecycle frozen
/remove-lifecycle stale

[Ankush Sharma]

Hi @thockin, can I take this up ? It would be a good starter issue for me.

[Daniel Smith]

Semantic deep equal is a pretty specialized thingy, I'd be surprised if
something else were a good replacement.

On Sun, Jun 3, 2018 at 1:28 AM Ankush Sharma <notifi...@github.com>
wrote:

> Hi @thockin <https://github.com/thockin>, can I take this up ? It would

> be a good starter issue for me.
>
> —

> You are receiving this because you were mentioned.

> Reply to this email directly, view it on GitHub

> <https://github.com/kubernetes/kubernetes/issues/55722#issuecomment-394146009>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAnglsxV5pRtUEkQGDxiiGC2nnPosFMUks5t4540gaJpZM4Qd1C7>
> .

[Deepika Pandhi]

found a similar discussion stretchr/testify#535

[行颠]

Does this still need to be discussed?
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/diff/diff.go#L57

ObjectDiff() ObjectGoPrintDiff() ObjectReflectDiff() use

 func legacyDiff(a, b interface{}) string {
	return cmp.Diff(a, b)
}

—
You are receiving this because you are on a team that was mentioned.

Reply to this email directly, view it on GitHub, or unsubscribe.