Re: [kubernetes/kubernetes] Remove the PersistentVolumeLabel Admission Controller (#52617)
Lucas Käldström
Changed the timeline for this to v1.10, sounds good as an initial plan?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Davanum Srinivas
/area platform/gce
/sig gcp
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen comment.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale
Davanum Srinivas
/unassign @dims
Josh Berkus
adding kind/cleanup to this issue so that it can stay in 1.10. Please update the kind if that is incorrect.
\kind cleanup
Michelle Au
/remove-lifecycle stale
/lifecycle frozen
@cheftako is working on running the cloud controller in gce, but it's not there yet, so we shouldn't remove the PV label admission controller yet.
Josh Berkus
reminder: this feature will be automatically dropped from 1.10 at Code Freeze tonight.
Kubernetes Submit Queue
[MILESTONENOTIFIER] Milestone Issue Labels Incomplete
Action required: This issue requires label changes. If the required changes are not made within 3 days, the issue will be moved out of the v1.10 milestone.
kind: Must specify exactly one of kind/bug, kind/cleanup or kind/feature.
Kubernetes Submit Queue
[MILESTONENOTIFIER] Milestone Issue Labels Incomplete
Action required: This issue requires label changes. If the required changes are not made within 2 days, the issue will be moved out of the v1.10 milestone.
Kubernetes Submit Queue
[MILESTONENOTIFIER] Milestone Issue Labels Incomplete
Action required: This issue requires label changes. If the required changes are not made within 1 day, the issue will be moved out of the v1.10 milestone.
Kubernetes Submit Queue
[MILESTONENOTIFIER] Milestone Removed From Issue
Important: This issue was missing labels required for the v1.10 milestone for more than 3 days:
Andrew Sy Kim
PVL admission controller was set for deprecation in 1.8, in 1.11 we'll be turning it off by default, users can still enable it if they need it. #64326
Andrew Sy Kim
^ I'm not 100% aware of the status of PVLs in AWS/GCE, this is just the deprecation plan we had in place a while back. If there are any known issues with doing this please let me know
Michelle Au
As long as the admission controller is not removed from cluster/gce/config-default.sh, then GCE will continue to work.
Lubomir I. Ivanov
/remove-sig cluster-lifecycle
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Andrew Sy Kim
/assign
/triage accepted
Davanum Srinivas
@cheftako is it time to try this again?
Michelle Au
I don't think we're ready. There's no replacement for it in the cloud controllers. The initial attempt at replacement using initializers was abandoned. I think we should consider a replacement using an admission webhook.
cc @mattcary
Michelle Au
Yes that sounds good.
Tim Bannister
What do we think the way forward looks like?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Kubernetes Triage Robot
This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.
You can:
- Confirm that this issue is still relevant with
/triage accepted(org members only) - Deprioritize it with
/priority important-longtermor/priority backlog - Close this issue with
/close
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Cici Huang
/remove-sig api-machinery
Since sig cloud provider has taken care of this one. :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Michelle Au
@andrewsykim @cheftako do you know what the latest status is on this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Davanum Srinivas
@msau42 i saw this go by the other day, please see https://github.com/cheftako/enhancements/blob/95a24e509a35faae89a8311f700439c0d50f2535/keps/sig-cloud-provider/2699-add-webhook-hosting-to-ccm/README.md#:~:text=functionality%20from%20the%20PersistentVolumeLabel%20(PVL)%20admission%20controller
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Davanum Srinivas
xref: kubernetes/org#4438
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Davanum Srinivas
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Jan Šafránek
For the record, replacement webhook: https://github.com/kubernetes-sigs/cloud-pv-admission-labeler
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Tim Hockin
Is this done now?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Davanum Srinivas
/close
@thockin yes! deleted in https://github.com/kubernetes/kubernetes/pull/124505/files
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Kubernetes Prow Robot
Closed #52617 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.