Re: [kubernetes/kubernetes] SharedInformer documentation is missing or hard to find (#65036)
Jonathan Basseri
/cc @kubernetes/sig-api-machinery-bugs
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Nikhita Raghunath
/kind documentation
Jonathan Basseri
Hi, it also seems like there is no documentation on how to use https://godoc.org/k8s.io/client-go/testing#Fake. (What is a reactor and what is an action?) Should I file a separate issue?
Nikhita Raghunath
Should I file a separate issue?
Yes, please create a separate issue for now. 👍
Though in the future, we should probably create an umbrella issue for all such client-go topics which are in dire need of docs. :)
Wenjia
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Jonathan Basseri
/remove-lifecycle stale
This is still on my list of things to look at.
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
—
Jonathan Basseri
/remove-lifecycle stale
@fedebongio Do you think this should be closed as a duplicate of kubernetes/client-go#483 ?
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
—
Jonathan Basseri
/remove-lifecycle stale
I will die on this hill.
fejta-bot
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
—
fejta-bot
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Kubernetes Prow Robot
Closed #65036.
Kubernetes Prow Robot
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Benjamin Reed
/reopen
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Kubernetes Prow Robot
@codeblooded: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Benjamin Reed
😭 -- is there any way we could reopen this? I struggled to find documentation on the informer factories. I learned how to use them from some blog posts on Medium.
Jonathan Basseri
/reopen
I agree, we don't have adequate docs on how to properly use informers. Proper testing of code that relies on informers is even trickier, and has less documentation.
Kubernetes Prow Robot
@misterikkit: Reopened this issue.
In response to this:
/reopen
I agree, we don't have adequate docs on how to properly use informers. Proper testing of code that relies on informers is even trickier, and has less documentation.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Kubernetes Prow Robot
Reopened #65036.
Daniel Smith
/lifecycle frozen
Patrick Ohly
@misterikkit do my changes in #112200 address your concerns regarding the documentation?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Jonathan Basseri
@misterikkit do my changes in #112200 address your concerns regarding the documentation?
OMG very yes. <3 I'd say it's fair to close this.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.
Kubernetes Prow Robot
Closed #65036 as completed via #112200.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are on a team that was mentioned.