Re: [kubernetes/kubernetes] document /watch prefix deprecation (#65147)
k8s-ci-robot
@liggitt: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Jordan Liggitt
these have been marked as deprecated in code for many releases, and all client accesses have switched to using the ?watch=true access method, but documentation was never updated
@kubernetes/sig-api-machinery-api-reviews @kubernetes/api-reviewers
You can view, comment on, or merge this pull request online at:
https://github.com/kubernetes/kubernetes/pull/65147
Commit Summary
- document /watch prefix deprecation
File Changes
- M api/openapi-spec/swagger.json (366)
- M api/swagger-spec/admissionregistration.k8s.io_v1alpha1.json (4)
- M api/swagger-spec/admissionregistration.k8s.io_v1beta1.json (8)
- M api/swagger-spec/apps_v1.json (30)
- M api/swagger-spec/apps_v1beta1.json (18)
- M api/swagger-spec/apps_v1beta2.json (30)
- M api/swagger-spec/autoscaling_v1.json (6)
- M api/swagger-spec/autoscaling_v2beta1.json (6)
- M api/swagger-spec/batch_v1.json (6)
- M api/swagger-spec/batch_v1beta1.json (6)
- M api/swagger-spec/batch_v2alpha1.json (6)
- M api/swagger-spec/certificates.k8s.io_v1beta1.json (4)
- M api/swagger-spec/events.k8s.io_v1beta1.json (6)
- M api/swagger-spec/extensions_v1beta1.json (34)
- M api/swagger-spec/networking.k8s.io_v1.json (6)
- M api/swagger-spec/policy_v1beta1.json (10)
- M api/swagger-spec/rbac.authorization.k8s.io_v1.json (20)
- M api/swagger-spec/rbac.authorization.k8s.io_v1alpha1.json (20)
- M api/swagger-spec/rbac.authorization.k8s.io_v1beta1.json (20)
- M api/swagger-spec/scheduling.k8s.io_v1alpha1.json (4)
- M api/swagger-spec/scheduling.k8s.io_v1beta1.json (4)
- M api/swagger-spec/settings.k8s.io_v1alpha1.json (6)
- M api/swagger-spec/storage.k8s.io_v1.json (4)
- M api/swagger-spec/storage.k8s.io_v1alpha1.json (4)
- M api/swagger-spec/storage.k8s.io_v1beta1.json (8)
- M api/swagger-spec/v1.json (84)
- M docs/api-reference/admissionregistration.k8s.io/v1alpha1/operations.html (4)
- M docs/api-reference/admissionregistration.k8s.io/v1beta1/operations.html (8)
- M docs/api-reference/apps/v1/operations.html (30)
- M docs/api-reference/apps/v1beta1/operations.html (18)
- M docs/api-reference/apps/v1beta2/operations.html (30)
- M docs/api-reference/autoscaling/v1/operations.html (6)
- M docs/api-reference/autoscaling/v2beta1/operations.html (6)
- M docs/api-reference/batch/v1/operations.html (6)
- M docs/api-reference/batch/v1beta1/operations.html (6)
- M docs/api-reference/batch/v2alpha1/operations.html (6)
- M docs/api-reference/certificates.k8s.io/v1beta1/operations.html (4)
- M docs/api-reference/events.k8s.io/v1beta1/operations.html (6)
- M docs/api-reference/extensions/v1beta1/operations.html (34)
- M docs/api-reference/networking.k8s.io/v1/operations.html (6)
- M docs/api-reference/policy/v1beta1/operations.html (10)
- M docs/api-reference/rbac.authorization.k8s.io/v1/operations.html (20)
- M docs/api-reference/rbac.authorization.k8s.io/v1alpha1/operations.html (20)
- M docs/api-reference/rbac.authorization.k8s.io/v1beta1/operations.html (20)
- M docs/api-reference/scheduling.k8s.io/v1alpha1/operations.html (4)
- M docs/api-reference/scheduling.k8s.io/v1beta1/operations.html (4)
- M docs/api-reference/settings.k8s.io/v1alpha1/operations.html (6)
- M docs/api-reference/storage.k8s.io/v1/operations.html (4)
- M docs/api-reference/storage.k8s.io/v1alpha1/operations.html (4)
- M docs/api-reference/storage.k8s.io/v1beta1/operations.html (8)
- M docs/api-reference/v1/operations.html (84)
- M staging/src/k8s.io/apiserver/pkg/endpoints/installer.go (13)
Patch Links:
- https://github.com/kubernetes/kubernetes/pull/65147.patch
- https://github.com/kubernetes/kubernetes/pull/65147.diff
k8s-ci-robot
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:api/OWNERS[liggitt]docs/api-reference/OWNERS[liggitt]staging/src/k8s.io/apiserver/OWNERS[liggitt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Jordan Liggitt
The /proxy prefix paths were removed in 1.10 in #59884
I'd like to get deprecation of the /watch prefix paths on the record for 1.11.
Zhonghu Xu
@hzxuzhonghu commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/endpoints/installer.go:
> @@ -382,7 +382,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
actions = appendIf(actions, action{"LIST", resourcePath, resourceParams, namer, false}, isLister)
actions = appendIf(actions, action{"POST", resourcePath, resourceParams, namer, false}, isCreater)
actions = appendIf(actions, action{"DELETECOLLECTION", resourcePath, resourceParams, namer, false}, isCollectionDeleter)
- // DEPRECATED
Haven't been deprecated long ago? Can we remove now?
Jordan Liggitt
@liggitt commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/endpoints/installer.go:
> @@ -382,7 +382,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
actions = appendIf(actions, action{"LIST", resourcePath, resourceParams, namer, false}, isLister)
actions = appendIf(actions, action{"POST", resourcePath, resourceParams, namer, false}, isCreater)
actions = appendIf(actions, action{"DELETECOLLECTION", resourcePath, resourceParams, namer, false}, isCollectionDeleter)
- // DEPRECATED
it wasn't formally announced, so not yet.
Zhonghu Xu
@hzxuzhonghu commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/endpoints/installer.go:
> @@ -382,7 +382,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
actions = appendIf(actions, action{"LIST", resourcePath, resourceParams, namer, false}, isLister)
actions = appendIf(actions, action{"POST", resourcePath, resourceParams, namer, false}, isCreater)
actions = appendIf(actions, action{"DELETECOLLECTION", resourcePath, resourceParams, namer, false}, isCollectionDeleter)
- // DEPRECATED
ic
Daniel Smith
I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...
cc @mbohlool to double check the open api spec
Jordan Liggitt
I was just saying on a api coverage spreadsheet that all these should be just deleted at this point...
cc @mbohlool to double check the open api spec
unfortunately, the endpoints are listed throughout the openapi spec, with no doc-visible deprecation notices
k8s-ci-robot
@liggitt: PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Aaron Crickenberger
@liggitt needs-rebase (also, I'm happy to lgtm after rebase unless you specifically need approval from the aformentioned reviewers)
Daniel Smith
/lgtm
/approve
k8s-ci-robot
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lavalamp, liggitt
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:api/OWNERS[lavalamp,liggitt]docs/api-reference/OWNERS[lavalamp,liggitt]staging/src/k8s.io/apiserver/OWNERS[lavalamp,liggitt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
k8s-ci-robot
@liggitt: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pull-kubernetes-verify | 204d70c | link | /test pull-kubernetes-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Aaron Crickenberger
/go/src/k8s.io/kubernetes/api/openapi-spec is out of date. Please run hack/update-openapi-spec.sh
/go/src/k8s.io/kubernetes/api/swagger-spec is out of date. Please run hack/update-swagger-spec.sh
k8s-ci-robot
New changes are detected. LGTM label has been removed.
Jordan Liggitt
regenerated, retagging
k8s-ci-robot
@liggitt: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-verify | 3cf4d77 | link | /test pull-kubernetes-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
fejta-bot
/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.
k8s-ci-robot
@liggitt: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pull-kubernetes-verify | 3cf4d77 | link | /test pull-kubernetes-verify |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
Aaron Crickenberger
/go/src/k8s.io/kubernetes/docs/api-reference is out of date. Please run hack/update-api-reference-docs.sh
... sure would have been nice if it said this last time
Aaron Crickenberger
/lgtm cancel
to stop fejta-bot from /retest spamming
Jordan Liggitt
third time's the charm
Kubernetes Submit Queue
/test all [submit-queue is verifying that this PR is safe to merge]
Kubernetes Submit Queue
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.
Kubernetes Submit Queue
Merged #65147 into master.
jethrogb
Why is this deprecated? This is a regression in terms of RBAC
Jordan Liggitt
Why is this deprecated?
The top-level path segment access patterns (for proxy and watch) were deprecated in favor of the proxy subresource and the watch query parameter around 1.2
This is a regression in terms of RBAC
That is incorrect, watch requests are still separately permissioned using the watch verb. Prior to this, there were two URLs that would make a watch request (/watch/… and …?watch=true), and this announces deprecation of the first
jethrogb
That is incorrect, watch requests are still separately permissioned using the watch verb.
With the Watch API, you can set watch permissions on a single named resource. With WatchList, you need to give permissions on all resources of a particular type. (Related kubernetes/kubectl#305)
Jordan Liggitt
you can still set watch permissions on a single named item, watched with ?watch=true&fieldSelector=metadata.name=<name>