Re: [kubernetes/kubernetes] Enable API chunking and promote to beta for 1.9 (#52949)
Michalis Kargakis
@kubernetes/sig-api-machinery-api-reviews
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Clayton Coleman
@smarterclayton pushed 2 commits.
- 49eb4ed Fill partial pages on the server rather than forcing client to
- 2d32c42 Promote continuation token schema to v1
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
k8s-ci-robot
@smarterclayton: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pull-kubernetes-unit | bfa15db | link | /test pull-kubernetes-unit |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-verify | bfa15db | link | /test pull-kubernetes-verify |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | bfa15db | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | bfa15db | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | bfa15db | link | /test pull-kubernetes-bazel-test |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | bfa15db | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | bfa15db | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | bfa15db | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-bazel | bfa15db | link | /test pull-kubernetes-e2e-gce-bazel |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-etcd3 | b695bfc | link | /test pull-kubernetes-e2e-gce-etcd3 |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | bfa15db | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
krmayankk
is there public documentation on API chunking ?
Clayton Coleman
Please see the proposal.
krmayankk
thanks @smarterclayton found it. Adding a link here for others to easily know what this PR does https://github.com/kubernetes/community/blob/58b1c30d95719749068497ba35dfe4c64b21aa72/contributors/design-proposals/api-machinery/api-chunking.md
krmayankk
@smarterclayton is chunking supported in client-go ?
krmayankk
ok i think i found that client-go does support chunking which is super useful, now just need to find which version of client-go supports it
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | b695bfc | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
Clayton Coleman
@smarterclayton pushed 1 commit.
- 6f60a71 Use watch cache when rv=0 even when limit is set
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Clayton Coleman
Ok, falls back to watch cache now. I think this is ready for review.
Chao Xu
/assign @jpbetz
k8s-ci-robot
@caesarxuchao: GitHub didn't allow me to assign the following users: jpbetz.
Note that only kubernetes members can be assigned.
In response to this:
/assign @jpbetz
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
—
Clayton Coleman
/test
Clayton Coleman
/test all
/test pull-kubernetes-kubemark-e2e-gce-big
k8s-ci-robot
@smarterclayton: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | 6f60a71 | link | /test pull-kubernetes-e2e-gce-bazel |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 6f60a71 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
Clayton Coleman
Tail latencies on a this run for density:
DELETE namespace endpoints 0.449 0.54 3.606
DELETE namespace pods 2.83 4.558 9.313
DELETE namespace replicationcontrollers 2.092 3.294 8.742
GET cluster clusterrolebindings 0.467 0.609 1.156
GET cluster namespaces 0.422 0.734 2.657
GET cluster nodes 0.107 0.134 0.226
GET namespace endpoints 0.443 0.676 3.064
GET namespace pods 0.46 0.755 3.363
GET namespace replicationcontrollers 0.452 0.581 2.809
GET namespace secrets 0.102 0.421 1.177
GET namespace serviceaccounts 0.37 0.429 0.429
GET namespace services 0.435 0.61 2.046
LIST cluster cronjobs 0.616 1.326 2.365
LIST cluster jobs 0.615 1.182 3.478
LIST cluster namespaces 0.893 1.539 2.214
LIST cluster nodes 22.511 24.396 28.188
LIST cluster persistentvolumes 0.737 0.887 1.154
LIST cluster pods 0.162 0.162 0.162
LIST cluster replicationcontrollers 0.109 0.216 0.216
LIST cluster services 0.741 1.782 1.85
LIST namespace limitranges 0.651 1.834 3.524
LIST namespace pods 10.892 11.72 31.21
LIST namespace resourcequotas 0.663 1.348 2.153
PATCH cluster clusterrolebindings 1.317 1.518 2.345
PATCH cluster nodes 1.576 2.41 5.028
POST cluster namespaces 0.836 0.906 0.906
POST namespace pods 1.046 2.248 7.463
POST namespace pods 1.258 2.066 6.892
POST namespace replicationcontrollers 1.19 1.873 5.588
POST namespace secrets 2.438 2.692 2.692
POST namespace serviceaccounts 0.932 1.017 1.017
PUT cluster apiservices 0.776 1.033 2.54
PUT namespace endpoints 1.143 2.113 5.338
PUT namespace pods 1.03 2.038 4.603
PUT namespace replicationcontrollers 1.028 1.652 3.792
PUT namespace serviceaccounts 0.982 1.17 1.17
Tail latencies on http://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-kubemark-500-gce/8733/artifacts/:
DELETE namespace pods 4.928 8.793 17.317
DELETE namespace replicationcontrollers 3.294 5.161 9.971
GET cluster clusterrolebindings 0.802 1.209 3.883
GET cluster namespaces 0.756 1.179 4.847
GET cluster nodes 0.186 0.265 0.766
GET namespace endpoints 0.734 1.154 3.746
GET namespace pods 0.777 1.417 5.515
GET namespace replicationcontrollers 0.698 1.015 3.677
GET namespace secrets 0.178 0.685 2.482
GET namespace serviceaccounts 0.555 0.864 0.864
GET namespace services 0.6 1.066 2.101
LIST cluster cronjobs 0.927 2.418 3.55
LIST cluster endpoints 0.164 0.177 0.177
LIST cluster jobs 0.975 2.913 5.839
LIST cluster namespaces 1.328 2.78 3.411
LIST cluster nodes 33.394 45.122 91.36
LIST cluster persistentvolumes 0.992 2.075 3.374
LIST cluster pods 0.194 0.194 0.194
LIST cluster replicationcontrollers 0.181 0.203 0.203
LIST cluster services 1.039 2.579 3.13
LIST namespace limitranges 1.005 2.012 4.238
LIST namespace pods 13.135 15.309 34.751
LIST namespace resourcequotas 1.184 2.839 3.38
PATCH cluster clusterrolebindings 1.975 2.669 3.285
PATCH cluster nodes 2.663 4.423 9.368
POST cluster namespaces 2.33 2.492 2.492
POST namespace pods 1.779 4.156 17.696
POST namespace pods 2.005 4.311 15.629
POST namespace replicationcontrollers 1.936 3.181 5.361
POST namespace secrets 4.293 5.09 5.09
POST namespace serviceaccounts 2.097 2.395 2.395
PUT cluster apiservices 1.076 1.746 3.196
PUT namespace endpoints 1.618 3.209 8.196
PUT namespace pods 1.769 3.792 11.106
PUT namespace replicationcontrollers 1.635 2.626 5.929
PUT namespace serviceaccounts 1.854 1.961 1.961
Clayton Coleman
Graphed density against 3 recent runs https://docs.google.com/spreadsheets/d/1ooBWLFmJVyzkr4L31SIHEqHTLoHQT0olSC7FtJ30rn0/edit?usp=sharing
99th tail latency is down almost across the board on this particular run. Will run more to see if this is just a fluke
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
Clayton Coleman
@kubernetes/sig-scalability-pr-reviews added a second data point - 25% or so latency reduction across the board on kubemark-500
Jordan Liggitt
Should check with non-kubemark scale test as well
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-gpu | 914f542 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|---|---|---|
| pull-kubernetes-e2e-gce-gpu | 914f542 | link | /test pull-kubernetes-e2e-gce-gpu |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | 914f542 | link | /test pull-kubernetes-unit |
Sen Lu
/retest
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-gpu | 914f542 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-unit | 914f542 | link | /test pull-kubernetes-unit |
| pull-kubernetes-bazel-test | 914f542 | link | /test pull-kubernetes-bazel-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-gpu | 914f542 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-bazel-test | 914f542 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-unit | 914f542 | link | /test pull-kubernetes-unit |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | 914f542 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-unit | 914f542 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | 914f542 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-unit | 914f542 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
Clayton Coleman
@kubernetes/sig-testing-misc https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/52949/pull-kubernetes-e2e-gce-etcd3/57209/?log#log had a test failure but reported success in the CI output
Jeff Grafton
@smarterclayton we set GINKGO_TOLERATE_FLAKES=y on PR jobs, so all tests get re-run if they fail once and only fail the run if they fail both times.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 09b1036 | link | /test pull-kubernetes-unit |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
Clayton Coleman
Ok, sorry, missed that announcement
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | 914f542 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 09b1036 | link | /test pull-kubernetes-unit |
| pull-kubernetes-bazel-test | 09b1036 | link | /test pull-kubernetes-bazel-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 09b1036 | link | /test pull-kubernetes-unit |
| pull-kubernetes-bazel-test | 09b1036 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | 09b1036 | link | /test pull-kubernetes-e2e-gce-etcd3 |
Clayton Coleman
Excellent, I was able to reproduce an issue OpenShift was seeing with watch cache disabled in this run https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/52949/pull-kubernetes-e2e-gce-etcd3/57255/artifacts/e2e-57255-master/kube-apiserver.log
List calls to the API server timeout against etcd 3.1.x for longer than 60s:
Trace[254194311]: [1m12.484197726s] [1m12.484192066s] About to write a response
E1003 00:52:37.908802 5 status.go:62] apiserver received an error that is not an metav1.Status: http: Handler timeout
E1003 00:52:37.909036 5 writers.go:143] apiserver was unable to write a JSON response: http: Handler timeout
I1003 00:52:37.911932 5 trace.go:76] Trace[1124568657]: "List /api/v1/namespaces/e2e-tests-replicaset-2csdw/serviceaccounts" (started: 2017-10-03 00:51:26.027164841 +0000
Trace[1124568657]: [1m11.880462423s] [1m11.88045551s] Listing from storage done
E1003 00:52:37.913165 5 status.go:62] apiserver received an error that is not an metav1.Status: http: Handler timeout
E1003 00:52:37.913808 5 writers.go:143] apiserver was unable to write a JSON response: http: Handler timeout
E1003 00:52:37.914246 5 writers.go:143] apiserver was unable to write a JSON response: http: Handler timeout
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | 09b1036 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | 09b1036 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-bazel-test | 09b1036 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | 09b1036 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-etcd3 | 09b1036 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | 88dfd14 | link | /test pull-kubernetes-bazel-test |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | 88dfd14 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | 88dfd14 | link | /test pull-kubernetes-e2e-gce-etcd3 |
Clayton Coleman
@smarterclayton pushed 1 commit.
- ceb4203 DO NOT MERGE - Try to use etcd 3.2.7
—
You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.
Kubernetes Submit Queue
@smarterclayton PR needs rebase
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
k8s-ci-robot
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-e2e-gce-etcd3 | 88dfd14 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | ceb4203 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-e2e-gce-etcd3 | 88dfd14 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 88dfd14 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | ceb4203 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | ceb4203 | link | /test pull-kubernetes-e2e-gce-etcd3 |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-verify | 88dfd14 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | ceb4203 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | ceb4203 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-kubemark-e2e-gce | ceb4203 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-unit | ceb4203 | link | /test pull-kubernetes-unit |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-verify | ceb4203 | link | /test pull-kubernetes-verify |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-build | ceb4203 | link | /test pull-kubernetes-bazel-build |
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | ceb4203 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-etcd3 | ceb4203 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-kubemark-e2e-gce | ceb4203 | link | /test pull-kubernetes-kubemark-e2e-gce |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | ceb4203 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-node-e2e | ceb4203 | link | /test pull-kubernetes-node-e2e |
k8s-ci-robot
| pull-kubernetes-kubemark-e2e-gce | ceb4203 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-unit | ceb4203 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-verify | ceb4203 | link | /test pull-kubernetes-verify |
| pull-kubernetes-node-e2e | ceb4203 | link | /test pull-kubernetes-node-e2e |
| pull-kubernetes-e2e-gce-etcd3 | e81e91a | link | /test pull-kubernetes-e2e-gce-etcd3 |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | ceb4203 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | ceb4203 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-kubemark-e2e-gce | ceb4203 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-verify | ceb4203 | link | /test pull-kubernetes-verify |
| pull-kubernetes-node-e2e | ceb4203 | link | /test pull-kubernetes-node-e2e |
| pull-kubernetes-e2e-gce-etcd3 | e81e91a | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-unit | e81e91a | link | /test pull-kubernetes-unit |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | e81e91a | link | /test pull-kubernetes-e2e-gce-bazel |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-gpu | e81e91a | link | /test pull-kubernetes-e2e-gce-gpu |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-kubemark-e2e-gce | e81e91a | link | /test pull-kubernetes-kubemark-e2e-gce |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-verify | ceb4203 | link | /test pull-kubernetes-verify |
| pull-kubernetes-e2e-gce-bazel | e81e91a | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | e81e91a | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-kubemark-e2e-gce | e81e91a | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-unit | fc544c7 | link | /test pull-kubernetes-unit |
k8s-ci-robot
k8s-ci-robot
k8s-ci-robot
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-verify | ceb4203 | link | /test pull-kubernetes-verify |
| pull-kubernetes-unit | fc544c7 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | fc544c7 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-kubemark-e2e-gce | fc544c7 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-etcd3 | fc544c7 | link | /test pull-kubernetes-e2e-gce-etcd3 |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-bazel-test | ceb4203 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-kops-aws | ceb4203 | link | /test pull-kubernetes-e2e-kops-aws |
| pull-kubernetes-unit | fc544c7 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | fc544c7 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-kubemark-e2e-gce | fc544c7 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-etcd3 | fc544c7 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-verify | fc544c7 | link | /test pull-kubernetes-verify |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | fc544c7 | link | /test pull-kubernetes-unit |
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | fc544c7 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-kubemark-e2e-gce | fc544c7 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-etcd3 | fc544c7 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-verify | fc544c7 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | fc544c7 | link | /test pull-kubernetes-bazel-test |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-gpu | fc544c7 | link | /test pull-kubernetes-e2e-gce-gpu |
| pull-kubernetes-kubemark-e2e-gce | fc544c7 | link | /test pull-kubernetes-kubemark-e2e-gce |
| pull-kubernetes-e2e-gce-etcd3 | fc544c7 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-verify | fc544c7 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | fc544c7 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-bazel-test | fc544c7 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 04db837 | link | /test pull-kubernetes-verify |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-e2e-gce-bazel | fc544c7 | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-e2e-gce-etcd3 | fc544c7 | link | /test pull-kubernetes-e2e-gce-etcd3 |
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 04db837 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | 04db837 | link | /test pull-kubernetes-bazel-test |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 04db837 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | 04db837 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-bazel | 04db837 | link | /test pull-kubernetes-e2e-gce-bazel |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
| pull-kubernetes-verify | 04db837 | link | /test pull-kubernetes-verify |
| pull-kubernetes-bazel-test | 04db837 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-bazel | e7e083f | link | /test pull-kubernetes-e2e-gce-bazel |
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-kubemark-e2e-gce-big | 914f542 | link | /test pull-kubernetes-kubemark-e2e-gce-big |
| pull-kubernetes-unit | 04db837 | link | /test pull-kubernetes-unit |
| pull-kubernetes-bazel-test | 04db837 | link | /test pull-kubernetes-bazel-test |
| pull-kubernetes-e2e-gce-bazel | e7e083f | link | /test pull-kubernetes-e2e-gce-bazel |
| pull-kubernetes-verify | e7e083f | link | /test pull-kubernetes-verify |
Clayton Coleman
@liggitt i think i'm ok with testing at this point - kubemark big is so finely tuned that it's difficult to get equivalent numbers with watch cache disabled. I think a follow up item generated by our discussion is:
- should the watch cache allow limiting (it can't do consistent listing) for certain use cases?
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
Clayton Coleman
ping @kubernetes/sig-api-machinery-pr-reviews PTAL
Dr. Stefan Schimanski
@sttts commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go:
> @@ -429,25 +429,26 @@ func decodeContinue(continueValue, keyPrefix string) (fromKey string, rv int64,
return "", 0, fmt.Errorf("continue key is not valid: %v", err)
}
switch c.APIVersion {
- case "v1alpha1":
+ case "meta.k8s.io/v1":
we have constants for this
Dr. Stefan Schimanski
> key = continueKey options = append(options, clientv3.WithRev(continueRV)) returnedRV = continueRV + case s.pagingEnabled && pred.Limit > 0: + rangeEnd := clientv3.GetPrefixRangeEnd(keyPrefix) + options = append(options, clientv3.WithRange(rangeEnd))
missing the RV parsing in this case.
Clayton Coleman
@smarterclayton commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go:
> @@ -429,25 +429,26 @@ func decodeContinue(continueValue, keyPrefix string) (fromKey string, rv int64,
return "", 0, fmt.Errorf("continue key is not valid: %v", err)
}
switch c.APIVersion {
- case "v1alpha1":
+ case "meta.k8s.io/v1":
These are not publicly accessible - even if we have constants I think we reserve the right to change this.
Clayton Coleman
@smarterclayton commented on this pull request.
In staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go:
> @@ -429,25 +429,26 @@ func decodeContinue(continueValue, keyPrefix string) (fromKey string, rv int64,
return "", 0, fmt.Errorf("continue key is not valid: %v", err)
}
switch c.APIVersion {
- case "v1alpha1":
+ case "meta.k8s.io/v1":
Also we don't take dependencies on metav1 in this package because the storage interface is supposed to abstract that.
Jordan Liggitt
one comment, lgtm otherwise
Clayton Coleman
@smarterclayton commented on this pull request.
> @@ -494,68 +507,94 @@ func (s *store) List(ctx context.Context, key, resourceVersion string, pred stor return err } - options = append(options, clientv3.WithRange(clientv3.GetPrefixRangeEnd(key))) + rangeEnd := clientv3.GetPrefixRangeEnd(keyPrefix)
I can add that, better to be restrictive.
Clayton Coleman
Added more restrictive control on resource version with tests, and also turned the error type into bad request so that clients know they used an invalid input.
Clayton Coleman
/test pull-kubernetes-kubemark-e2e-gce-big
k8s-ci-robot
@smarterclayton: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-bazel-test | ce0dc76 | link | /test pull-kubernetes-bazel-test |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
k8s-ci-robot
@smarterclayton: The following tests failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-verify | ce0dc76 | link | /test pull-kubernetes-verify |
Clayton Coleman
/retest
Clayton Coleman
All green, label on, kubemark continues to show improvement
Kubernetes Submit Queue
/test all [submit-queue is verifying that this PR is safe to merge]
Kubernetes Submit Queue
Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions here.
Kubernetes Submit Queue
Merged #52949.
k8s-ci-robot
@smarterclayton: The following test failed, say /retest to rerun them all:
| Test name | Commit | Details | Rerun command |
|---|
| pull-kubernetes-e2e-gce-etcd3 | ce0dc76 | link | /test pull-kubernetes-e2e-gce-etcd3 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—