Structured Logging targeting beta for 1.21!

[Elana Hashman]

Greetings programs,

SIG Instrumentation has undertaken an ambitious initiative to migrate Kubernetes to structured logging. For beta in 1.21, we have committed to migrating the kubelet, and are allowing other components to be migrated on a best-effort basis. This is a great opportunity for new contributors to get involved!

• KEP issue: https://github.com/kubernetes/enhancements/issues/1602
• KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging#beta
• Migration guide: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
• Migration issue for Kubelet, with instructions for authors and reviewers: https://github.com/kubernetes/kubernetes/issues/98976
• Contacts: #sig-instrumentation on Slack, please mention @ehashman and/or @serathius

As this is a beta initiative, we expect that there will be improvements made to the guide and documentation as we complete the first steps of the migration. If you have any questions, please do reach out!

Cheers,

- e

[Elana Hashman]

Hello k-dev + SIG Instrumentation,

Structured logging PRs for the 1.21 release are now tracked on a project board. We are currently following 29 PRs on the board. The tracking issues on k/k and k/enhancements have been updated to link to the project board.

Please check the board before opening a PR, to ensure your change hasn't already been made! Only kubelet PRs are being prioritized for the 1.21 release; all others are backlog priority and likely will not receive timely reviews, so you may want to hold off on those.

We definitely need more reviewers. If you'd like to help out with reviews, please see the reviewer instructions on #98976.

It's been great seeing all the first-time and new contributors working on the structured logging migration! For more info, please see the links in my original email below.

Cheers,

- e

[Lubomir I. Ivanov]

hello,

on slack we discussed that we should skip kubectl and kubeadm from
this effort in 1.21.

yet we saw a number of PRs for kubeadm:
https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+is%3Aopen+label%3Aarea%2Fkubeadm
(see PRs titled "migrate ....")


maybe it should have been outlined that these components are out of scope in:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
or
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

is migration-to-structured-logging.md the place to PR such a change?

commented similar here:
https://github.com/kubernetes/kubernetes/pull/99327#pullrequestreview-597043143

lubomir
--

> --
> You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/CAH1uJ6XUM_aC4149Xji%2BXxX%3DzoqBOmLU25PG3KVh4M4h5A%3Dy6g%40mail.gmail.com.

[Elana Hashman]

Hi Lubomir,

We have been quite clear in the KEP and tracking issues that only the kubelet is in scope for 1.21. Any other components are best effort.

You are free to close structured logging PRs against kubectl/kubeadm. I am happy to accept changes to the KEP or migration guide that explicitly mark those components as out of scope.

- e

[Lubomir I. Ivanov]

On Wed, 3 Mar 2021 at 03:28, Elana Hashman <ehas...@redhat.com> wrote:
>
> Hi Lubomir,
>
> We have been quite clear in the KEP and tracking issues that only the kubelet is in scope for 1.21. Any other components are best effort.
>
> You are free to close structured logging PRs against kubectl/kubeadm. I am happy to accept changes to the KEP or migration guide that explicitly mark those components as out of scope.
>

since i saw a couple of batches of PRs against kubeadm from different
contributors and given kubectl also has a number of calls to klog that
users might attempt to migrate too, i PRed the KEP with hope to make
this clearer:
https://github.com/kubernetes/enhancements/pull/2549


lubomir
--

[Elana Hashman]

Thanks for your PR!

I have clarified all remaining files that need to be migrated for 1.21 in the kubelet tracking issue.

New contributors should use this comment to guide their migrations. I strongly recommend opening PRs before EOD Mar. 5, as code freeze is fast approaching next week.

Hope that helps,

- e

[Sladyn nunes]

Hello k-dev + SIG Instrumentation,

Based on the updated list by Elana Hashman on the remaining files, I managed to update the list based on the efforts of contributors over the past 15 hours, so maybe those hoping to kind of get their PRs in by the EOD March 5th can take a look at this updated comment.

Hope this helps.

Thanks and Regards

To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/CAH1uJ6U1EXdxqPTdcdFnwoAXMR%3DKZ6SiXAaDUsmytfo0F9UsAw%40mail.gmail.com.