Remove golint based verification

[Davanum Srinivas]

Somehow this did not make it to the list. trying again.

---------- Forwarded message ---------
From: Davanum Srinivas <dav...@gmail.com>
Date: Fri, Jan 15, 2021 at 9:24 AM
Subject: Remove golint based verification
To: Kubernetes developer/contributor discussion <kuberne...@googlegroups.com>

Folks,

fyi, the verify-golint while being a good thing to shoot for, has ended up to be a big burden on reviewers. So the proposal is to drop this verification, please see:

https://github.com/kubernetes/kubernetes/pull/98063

original issue that was used to crowdsource golint verification is here:

https://github.com/kubernetes/kubernetes/issues/68026

Please chime in either of those or drop a note here with thoughts.

thanks,

Dims

PS: we could revisit switching a bunch of our verifications to golangci-lint, if you are interested in efforts of this kind, please join #k8s-code-organization

--

Davanum Srinivas :: https://twitter.com/dims

[Benjamin Elder]

+1, golint itself does not recommend blocking on it in CI and we run more linters these days.

--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/c449577c-a338-4899-a867-8788a1a7d694n%40googlegroups.com.

[ehas...@redhat.com]

+1, I've seen a lot of churn related to golint fix PRs and spent a lot of review time on it.