Fwd: /lgtm acting as /approve in k/community

[Christoph Blecker]

Hi k-dev,

Please see below regarding a change we are canary-ing in k/community. This also relates back to this k-dev thread: https://groups.google.com/d/msg/kubernetes-dev/PJJxV9roXI8/aIeHQdKoBwAJ

Cheers,

Christoph

---------- Forwarded message ---------
From: Christoph Blecker <cble...@gmail.com>
Date: Thu, 26 Apr 2018 at 10:28
Subject: /lgtm acting as /approve in k/community
To: <kubernetes-s...@googlegroups.com>

Hey ContribEx,

Over the last few weeks, there have been a number of discussions around /lgtm vs /approve, and the principal of least astonishment.

There are a number of discussions and background on this:

https://groups.google.com/d/msg/kubernetes-sig-contribex/hMehQkBMBho/xNH23r_NCgAJ

https://github.com/kubernetes/test-infra/issues/6589

https://github.com/kubernetes/test-infra/pull/7504

https://groups.google.com/d/msg/kubernetes-sig-contribex/k_k97HFMLDk/Pv41d93ZBwAJ

We are going to roll out a change so that /lgtm no longer automatically approves a PR. If you want to approve a PR in k/community as well, you need to explicitly use the /approve command. We are rolling this out to just k/community first, but with the intent of canary-ing it to all of the kubernetes org.

If there are any unforeseen issues or feedback once this rolls out, please let me know!

Cheers,

Christoph