[ACTION REQUIRED] Kubernetes is now built with Golang 1.16!

77 views
Skip to first unread message

Stephen Augustus

unread,
Mar 2, 2021, 12:28:45 PM3/2/21
to Kubernetes developer/contributor discussion
Kubernetes Community,

You may have noticed that some of your PRs to kubernetes/kubernetes are failing tests that check the diff on go.mod or go.sum files, including:
  • pull-kubernetes-dependencies
  • pull-kubernetes-verify
That's because between last night and roughly 30 minutes ago, we were in a transitional phase as we prepared for the go1.16 update: https://github.com/kubernetes/kubernetes/pull/98572

Now that that PR has merged, I'd suggest a few things:
  • Update your local Golang to go1.16. gimme is a great option if you work on multiple projects and have to manage multiple local installations of Golang
  • Rebase your open kubernetes/kubernetes PRs
  • If your PR is making changes to dependencies (go.mod/go.sum), try running the following commands:
    • hack/update-internal-modules.sh
    • hack/lint-dependencies.sh
    • hack/update-vendor.sh
  • In a separate commit, commit those changes (example: "generated: Run hack/update-vendor.sh")
If you continue to run into go1.16 issues, please leave us a note on the tracking issue or join us on Slack on the already-active go1.16 tracking thread.

Anecdotally, I believe this is the first larger PR that landed after the bazel removal.
I was immediately unblocked by that removal, so I'd be remiss if I didn't shoutout Ben, Aaron, and the SIG Testing crew for driving that effort forward!

Thank you as well to the usual crew (RelEng, @liggitt, @dims) for helping with getting this across the finish line ahead of Code Freeze!

-- Stephen
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages