Disabling the cherrypick-auto-approve munger

19 views
Skip to first unread message

Aaron Crickenberger

unread,
Apr 12, 2018, 1:40:57 PM4/12/18
to Kubernetes developer/contributor discussion
Hi all,

I'd like to disable the cherrypick-auto-approve munger: https://github.com/kubernetes/test-infra/pull/7653

Over time we have tribally forgotten that it exists, and expect the label `cherrypick-approved` to be manually applied by the branch / path release manager. 

To quote Anthony Yeh, "as a former patch release manager, I can't think of any three words scarier than `cherrypick-auto-approve`

If you are someone who wants to cherrypick a PR into a release branch, nothing changes for you.  Docs on how to do that are getting clarified here: https://github.com/kubernetes/community/pull/1980

If you are a patch or release branch manager, `cherrypick-approved` won't magically show up sometimes.  Look for an e-mail once this change is deployed.

- aaron

Aaron Crickenberger

unread,
Apr 17, 2018, 5:58:57 PM4/17/18
to Kubernetes developer/contributor discussion
Hi all,

The change has been deployed.  No more cherrypick-auto-approve munger.

- aaron
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages