[PodPreset] Enabling PodPreset support injecting init-containers and side-car containers

173 views
Skip to first unread message

Guang Ya Liu

unread,
Jul 3, 2017, 1:00:52 AM7/3/17
to Kubernetes developer/contributor discussion
Hi,

I found that now the PodPreset only support injecting Env, EnvFrom, and VolumeMounts to a PodSpec, sometimes, many PodSpec may share same init-container and side-car container, such as istio, so any plan to support injecting init-container and side-car containers via PodPreset?

Thanks,

Guangya

Sunil Arora

unread,
Jul 5, 2017, 4:58:27 PM7/5/17
to Guang Ya Liu, Kubernetes developer/contributor discussion
Hi Guang,

Use case for injecting containers using PodPreset has been discussed and is on the roadmap, but has not been prioritized for Beta yet. If you are blocked on it, you should explore using "Initializers" which is introduced in 1.7 release. Here is the link --> https://kubernetes.io/docs/admin/extensible-admission-controllers/



--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-dev+unsubscribe@googlegroups.com.
To post to this group, send email to kubernetes-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-dev/56a8901c-e25c-41f1-bcde-e8fc34a6343f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Guang Ya Liu

unread,
Jul 6, 2017, 3:56:13 AM7/6/17
to Sunil Arora, Kubernetes developer/contributor discussion
Thanks Sunil, this can help me, but I may need to develop a webhook for this. 

I still think using PodPreset is the direction for this problem, can you please share me the roadmap of PodPreset and what is the priority of this?

Thanks,

Guangya

On Thu, Jul 6, 2017 at 4:58 AM, Sunil Arora <sunil...@google.com> wrote:
Hi Guang,

Use case for injecting containers using PodPreset has been discussed and is on the roadmap, but has not been prioritized for Beta yet. If you are blocked on it, you should explore using "Initializers" which is introduced in 1.7 release. Here is the link --> https://kubernetes.io/docs/admin/extensible-admission-controllers/


On Sun, Jul 2, 2017 at 10:00 PM, Guang Ya Liu <gyli...@gmail.com> wrote:
Hi,

I found that now the PodPreset only support injecting Env, EnvFrom, and VolumeMounts to a PodSpec, sometimes, many PodSpec may share same init-container and side-car container, such as istio, so any plan to support injecting init-container and side-car containers via PodPreset?

Thanks,

Guangya

--
You received this message because you are subscribed to the Google Groups "Kubernetes developer/contributor discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-dev+unsubscribe@googlegroups.com.
To post to this group, send email to kuberne...@googlegroups.com.

Sunil Arora

unread,
Jul 7, 2017, 7:53:17 PM7/7/17
to Guang Ya Liu, Kubernetes developer/contributor discussion

Guang Ya Liu

unread,
Jul 7, 2017, 11:19:20 PM7/7/17
to Sunil Arora, Kubernetes developer/contributor discussion
Cool, thanks Sunil!

Guang Ya Liu

unread,
Jul 8, 2017, 3:45:25 AM7/8/17
to Sunil Arora, Kubernetes developer/contributor discussion
There is already a PR https://github.com/kubernetes/kubernetes/pull/48505 fixing this.
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages