Phabricator feed and Differentials

11 views
Skip to first unread message

nik...@melnichenko.name

unread,
Feb 12, 2018, 11:22:58 PM2/12/18
to krusader-devel
Hi Krew,

I've submitted a code review through arc and specified #krusader as a reviewer. For some reason, it doesn't appear on the project feed. Any ideas? Other actions like updated membership are there. Feel free to suggest "the right way". BTW, have you got any notification about the code review?

Thanks,
Nikita.

Yuri Chornoivan

unread,
Feb 13, 2018, 12:08:13 AM2/13/18
to krusade...@googlegroups.com
Hi,

It seems that spreading data through code review system works just fine (at least it works for this and others reviews so far). Please wait a bit for someone to review.

Best regards,
Yuri

Nikita Melnichenko

unread,
Feb 15, 2018, 12:38:56 AM2/15/18
to krusade...@googlegroups.com, Yuri Chornoivan
Hi Yuri,

Thanks for checking. Still, the project feed doesn't show anything about the CR even though it's been accepted and closed already. Not only this, entries regarding D10385 are also missing. Looks like some bug in Phabricator. I haven't found a place to report it. Does anyone know? Should we report to upstream?

Thanks,
Nikita.

Toni Asensi Esteve

unread,
Feb 16, 2018, 5:37:07 AM2/16/18
to krusade...@googlegroups.com

> Thanks for checking. Still, the project feed doesn't show anything about

> the CR even though it's been accepted and closed already. Not only this,

> entries regarding D10385 are also missing. Looks like some bug in

> Phabricator. I haven't found a place to report it. Does anyone know?

> Should we report to upstream?

>

Hi! I compared

https://phabricator.kde.org/tag/krusader/

and

https://phabricator.kde.org/project/view/79/

and looked very, very similar. Maybe you can try adding the tag "Krusader" to your differentials, and see if it makes any difference.

 

Greetings!

nik...@melnichenko.name

unread,
Feb 17, 2018, 2:25:37 AM2/17/18
to krusader-devel
Hi Toni,

Indeed, very similar. How do you add tags? I looked at `arc diff` options and I don't see anything relevant.

Thanks,
Nikita.

Toni Asensi Esteve

unread,
Feb 17, 2018, 6:49:46 AM2/17/18
to krusade...@googlegroups.com

Hi!

 

> Indeed, very similar. How do you add tags? I looked at `arc diff` options

> and I don't see anything relevant.

 

I've tried going to https://phabricator.kde.org/D10385, clicking on "Edit Revision", going to the "Tags" section, adding "Krusader" there, and saving changes. And now D10385 news appear in https://phabricator.kde.org/project/view/79/ and https://phabricator.kde.org/tag/krusader/ :-)

 

> Thanks,

> Nikita.

 

Thank you for your work :-)

Toni

 

 

Reply all
Reply to author
Forward
0 new messages