Breeze icons for krusader

[Andreas K]

Hi,

I'm one of the breeze-icon designer and want to make krusader fit for breeze. now it look like that:

https://dl.dropboxusercontent.com/u/1642456/krusader.png

In oxygen it works nice but in breeze there are some app specific icons which should be changed. I wrote an blog post about how I will fix this problem (https://kdeonlinux.wordpress.com/2015/08/07/breeze-icons-in-plasma-5-4-and-future-work/)

So I'd like to make the missing breeze icons for krusader and one of the developers change the behavior that when the is an icon available in the main icon set krusader will use the global icon instead of the app icon from the krusader source.

that's it. before I push the app specific krusader icons into breeze you get them for your feedback.

would it be ok for you?

Cheers
Andreas K

[Davide Gianforte]

First, I've alredy read your post and I agree with it; I use breeze-dark theme and I'm fine with it.

ATM, krusader always try to load icons from the current theme (using QIcon::fromTheme(icon) defined in krusader/actionsbase:42 - ActionsBase::createAction), if there is no suitable icon, it uses the internal one (oxygen-based).

As breeze is the default theme, it makes no sense if we ship breezed icon with krusader (I agree with your solution 2), so for all missing icons we'll:

- find a suitable existing icon (like for Trash in the main toolbar)
- create a new one (or slightly modify one existent)

the main krusader icon should be ok, but I'd keep the lines as in the old icon.

Thanks
Davide

[kainz.a]

I'm sorry Davide but I don't get it when I copy an kr_jumpback.svg into /usr/share/icons/breeze/actions/toolbar-small I don't see this icon in Go -> Jump Back.

what do I wrong.

You can contact me via irc in #plasma and #kde-dev

andreas_k

[kainz.a]

Hi all,

thanks David for the change of the ICON_INSTALL_DIR with this change the Krusader icons would come first from /usr/share/icons/ and when there are no icons from /usr/share/kde4/apps/krusader/icons which are from the source.

I have to possibilities with the icons

1. add the krusader specific icons to breeze (usr/share/icons/)

2. change the source that most of the time no new icons are needed

I will prefer the second solution cause when you change to any other icon set krusader will look always consistent cause the standard icons are available not only in breeze also in oxygen, humanity, gnome, nitrux, ...

so I collect an calc sheet with the needed changes in the source
https://dl.dropboxusercontent.com/u/1642456/VDG/krusader/KrusaderIconStandardization.xls

I can also make the changes myself but than I need someone to voluntary me. Which is what I prefer, cause I have the same issue in a lot of kde apps and it is always better when you can do it yourself than ask for help.

Krusader Konfigurator
=====================

https://dl.dropboxusercontent.com/u/1642456/VDG/krusader/KrusaderKonfigurator.png

- you have a lot of settings (feature of krusader) if you like that someone will have a look at please open an thread in the forum (https://forum.kde.org/viewforum.php?f=285) Heiko have really good ideas of simple and complex configuration

- All sidebar icons from ONE section (actions, apps, ...) don't mix between monochrome and color
    - colors     kcolorchooser             ->     actions/color-picker
    - general    preferences-other         ->    actions/system-run
    - advanced    dialog-warning            ->    dialog-worning (new icon)    (rename to wornings)
    - archives    utilities-file-archiver ->    actions/archive-insert
    - depencies    kr_dependencies            ->    actions/debug-run
    - protocols    kde                     ->    actions/document-preview
   
- Protokols
    - can you use the mimetype icons at defined links (when you need some mimetype icons I will make them)

Bugs
==========

https://dl.dropboxusercontent.com/u/1642456/VDG/krusader/KrusaderBreeze.png

I move all icons into the toolbar where no icons are available. I don't know why but I think it is something like wrong icon name or wrong behavior. e.o. for the sort you don't need for every different sort an icon.

Keep up your great work and I hope someone can help me to fix the small issues. I will also maintain the oxygen icons so. Also in oxygen the "new" icons are included into /usr/share/icons. What you will do with your source code icons we can discuss when I'm finished.

Thanks a lot

Andreas K

[Simon Persson]

Hello Andreas,

 

About two months ago I asked for help on this mailing list, I mentioned that we need to sort out icons for krusader and talk to the VDG about it. So I was very happy now to see your email.

 

I just had a quick look at your spreadsheet now and I'm wondering where you got the icon names in the first column of the actions page? A lot of them I can not find, for example there is no mentioning of "bookmark_add", "bookmark_folder" or "editcopy" in the whole of krusader.

 

I think there are icons currently installed by krusader that are not being used so I want to start by removing them. Perhaps I can have some time this coming week, not sure.

Anyway, after that I can start changing code to use the replacement icon names you suggest.

 

But Davide, if you want to start working on this... just go ahead, don't let this email stop you! :)

 

We can use your spreadsheet as a working document and send an updated version after changes have been done. Just to see what is left to discuss after those changes.

 

 

When it comes to reorganizing the configuration dialog for krusader I would be happy to review any work done on this but I think for me personally if I would do any "feature work" on krusader it would probably be something else, like adding support for Activities or adding kauth support so we can get rid of "root mode" krusader.

I'm just saying that, to not waste time for the VDG, it would be best to have a developer available with time and motivation to work on the configuration dialog before starting any HIG reviews or discussions.

 

Thank you very much for your help!

 

Simon

[kainz.a]

I upload the sheet to google docs so Simon and someone else it would be nice if we can work there together.

https://docs.google.com/spreadsheets/d/1QeofZQmORgu-4zcfjTsIwZhzMqRJf36plKJDdv7I6mU/edit?usp=sharing

cheers

Andreas

[kainz.a]

Hi,

go through the source code and change to use more standard icons. Now only 7 app specific isons where needed.

https://dl.dropboxusercontent.com/u/1642456/VDG/krusader/Krusader.zip

The Review Request for the changes
https://git.reviewboard.kde.org/r/124958/

and the link to the breeze icons where the app specific icons are included (breeze-dark will come when we are finished, sorry)
https://github.com/NitruxSA/breeze-icon-theme

The icons come to kde:share github is only our working dictionary but at Randa Uri and I will discuss to use only kde infrastructure.

As I'm not an coder PLEASE make an review and give me feedback. There are several "icons" they are still missing but also were missing in the past e.o. useractions -> User interface -> sort

hope you enjoy

cheers

Andreas

[Simon Persson]

On August 28, 2015 11:30:38 kainz.a wrote:

> Hi,

>

> go through the source code and change to use more standard icons. Now only

> 7 app specific isons where needed.

>

> https://dl.dropboxusercontent.com/u/1642456/VDG/krusader/Krusader.zip

>

> The Review Request for the changes

> https://git.reviewboard.kde.org/r/124958/

>

 

I cannot see that you have uploaded any diff for us to review there, normally I just run "git diff > file.diff" and upload file.diff to the review request.

 

> and the link to the breeze icons where the app specific icons are included

> (breeze-dark will come when we are finished, sorry)

> https://github.com/NitruxSA/breeze-icon-theme

 

Nice work! If you think some of these icons can be generally useful (not only for krusader I mean), could they be renamed?

 

I have now removed unused icons from krusader and updated the spreadsheet with status.

 

>

> The icons come to kde:share github is only our working dictionary but at

> Randa Uri and I will discuss to use only kde infrastructure.

>

> As I'm not an coder PLEASE make an review and give me feedback. There are

> several "icons" they are still missing but also were missing in the past

> e.o. useractions -> User interface -> sort

>

 

If you find krusader code that tries to load icons that do not exist, please list the exact name here (and perhaps include suggestion for a better alternative to use).

 

Thanks again for your help!

Simon

[kainz.a]

Hi,

anny feedback about the review about use standard icon names? https://git.reviewboard.kde.org/r/124958/

If you prefere to not change the source code I can also move the missing krusader icons into breeze. than you only have to change the cmake file.

I would also ask if you are interested into some mockups or visuals for krusader. Not everything new, but maybe an cleanup (simple by default, powerful when needed). I know Dolphin is for the standard user and krusader for the advanced user but maybe we can find also some improvements for power users too?

If the VDG should do some visuals please start an thread at our forum (https://forum.kde.org/viewforum.php?f=285).

Thanks

Andreas