Rework of widgets focusing

8 views
Skip to first unread message

Gengis Dave

unread,
Dec 29, 2019, 8:58:34 AM12/29/19
to krusade...@googlegroups.com
Hi all,

in reference of bug https://bugs.kde.org/show_bug.cgi?id=414831 (cant focus embedded terminal with ctrl+down), I looked to the code involving this.

At the moment, there are two modes to move up/down between the widgets - Location bar, Panel, Sidebar, Embedded terminal, Command Line.

The first one is a configurable shortcut, by default CTRL+SHIFT+UP/DOWN, you can move (from top to bottom) between:

Panel View (brief or detailed)
Side Bar (if visible)
Embedded Terminal (if activated)
Command Line

The second one is hardcoded with CTRL+UP/DOWN, and lets you to move between:

Location Bar (edit mode)
Panel View
Command Line

it also let you to move out of the Embedded Terminal but not to move into.

While the original ticket could be closed with a "use this shortcut" and modify accordingly the documentation, it would be better to merge this two methods.

My proposal is to leave the configurable shortcut only, adding the possibility to go in edit mode in the location bar. This will require changes in the eventFilter methods and in the class KrusaderView.

What do you think about it?

Thank you very much

Nikita Melnichenko

unread,
Dec 30, 2019, 3:32:55 AM12/30/19
to krusade...@googlegroups.com, Gengis Dave
Hi Davide,

I support your proposal. The functionality is almost the same for the two shortcuts, it's good to eliminate hard-coded settings and I don't see a use case of using separate shortcuts.

Thanks,
Nikita.

Gengis Dave wrote:
--
You received this message because you are subscribed to the Google Groups "krusader-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to krusader-deve...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/krusader-devel/CADB%3D0tr780DkQ7Gh7kEaquuxYGhfCmZqi4aE1oA9vUSBQh%3DtTA%40mail.gmail.com.


Reply all
Reply to author
Forward
0 new messages