Errors in snickerdoodle-linux repo

[Nick Burkitt]

Hi Guys.

The krtkl repo contains errors. 

I've found several pairs of files whose names differ only by case, where the upper-case file has been clobbered by, and is now a slightly out-of-date version of, the lower-case file.

The first example I found was net/netfilter/xt_DSCP.c and net/netfilter/xt_dscp.c. 

And include/uapi/linux/netapi/xt_DSCP.h.

And net/netfilter/xt_RATEEST.c and include/uapi/linux/netapi/xt_RATEEST.h.

And net/netfilter/xt_HL.c.

And include/uapi/linux/netapi/xt_TCPMSS.h.

And include/uapi/linux/netapi/xt_MARK.h.

I've tried reverting the problem files to the linux-xlnx repo's "zynqmp-dt-for-4.14" tag, but I still can't get the kernel to build. It's likely that I haven't found all the clobbered files.

Help?

-Nick

[Russell Bush]

Hey Nick,

I’ve checked the repo contents on GitHub and it looks like those files are still intact. The clobbering of those files often happens when you clone the repo to a Windows or OS X file system as the upper case and lower case files cannot coexist in those file systems. I’ve personally run into that issue before when cloning the repo to an OS X file system before sharing it with a Linux build host. Let me know if this helps you or if you still have issues building directly from a Linux host.

russell bush | cdo
c 310.488.0453

krtkl inc.
350 townsend street, suite 301a
san francisco, ca 94107
t 415.857.4857
http://krtkl.com

NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.

--
You received this message because you are subscribed to the Google Groups "snickerdoodle forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to krtkl-snickerdo...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/krtkl-snickerdoodle/9a97de9e-a7b1-4fab-b5d0-0574cd278e6b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Nick Burkitt]

Compare your copies of net/netfilter/xt_DSCP.c and xt_dscp.c. Then compare your xt_DSCP.c to the one in the linux-xlnx repo. 

I'm building on Ubuntu 16.04.

[Nick Burkitt]

Here's the list of files that I've had to fix so far (some may not have been strictly necessary):

Changes not staged for commit:

  (use "git add <file>..." to update what will be committed)

  (use "git checkout -- <file>..." to discard changes in working directory)

modified:   include/uapi/linux/netfilter/xt_CONNMARK.h

modified:   include/uapi/linux/netfilter/xt_DSCP.h

modified:   include/uapi/linux/netfilter/xt_MARK.h

modified:   include/uapi/linux/netfilter/xt_RATEEST.h

modified:   include/uapi/linux/netfilter/xt_TCPMSS.h

modified:   include/uapi/linux/netfilter_ipv4/ipt_TTL.h

modified:   include/uapi/linux/netfilter_ipv4/ipt_ttl.h

modified:   include/uapi/linux/netfilter_ipv6/ip6t_HL.h

modified:   net/netfilter/xt_DSCP.c

modified:   net/netfilter/xt_HL.c

modified:   net/netfilter/xt_RATEEST.c

And one is completely missing from the krtkl repo:

Untracked files:

  (use "git add <file>..." to include in what will be committed)

net/netfilter/xt_hl.c

[Nick Burkitt]

One clarification - the kernel builds without problems; the errors occur when building the modules.

[Nick Burkitt]

I encourage you not to blow this off as a rookie Windows-user mistake (at least not on my part). To that end, I'll do what I suggested you do, and compare xt_DSCP.c and xt_dscp.c directly in both the krtkl and Xilinx repositories. You don't even need a diff tool to see that the files in the krtkl repo are identical except for one line. It's equally obvious that the files in the Xilinx repo are very different.

krtkl repository: xt_DSCP.c, xt_dscp.c

Xilinx repository: xt_DSCP.c, xt_dscp.c