simple patch, license headers

[Ian Monroe]

The included patch is need for source directory != build directory for
QInfinity. I would recommend building in this way btw :) keeps your
source directory clean.

Anyways in Kobby, I noticed that none of the files have license
headers. Some examples are at:
http://techbase.kde.org/Policies/Licensing_Policy

Its a requirement of the GPL that such a license header appear with
all copyright holders listed.

diff --git a/libqinfinity/CMakeLists.txt b/libqinfinity/CMakeLists.txt
index ba7d970..02e21b7 100644
--- a/libqinfinity/CMakeLists.txt
+++ b/libqinfinity/CMakeLists.txt
@@ -75,7 +75,7 @@ set(QInfinity_HDRS

QT4_AUTOMOC(${QInfinity_SRCS})

-include_directories(${LIBINFINITY_INCLUDES} ${LIBINFTEXT_INCLUDES})
+include_directories(${LIBINFINITY_INCLUDES} ${LIBINFTEXT_INCLUDES} $
{CMAKE_CURRENT_BINARY_DIR})

ADD_LIBRARY(qinfinity SHARED ${QInfinity_SRCS})

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index 29a13a2..98c98cb 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -4,7 +4,7 @@ find_package(Libinfinity REQUIRED)
set(QT_USE_QTNETWORK true)
INCLUDE(${QT_USE_FILE})

-include_directories(${LIBINFINITY_INCLUDES} ${CMAKE_SOURCE_DIR}/
libqinfinity)
+include_directories(${LIBINFINITY_INCLUDES} ${CMAKE_SOURCE_DIR}/
libqinfinity ${CMAKE_CURRENT_BINARY_DIR})

QT4_AUTOMOC(guibrowser.cpp
connection.cpp

[Gregory Haynes]

On Saturday 02 May 2009 15:37:53 Ian Monroe wrote:
> The included patch is need for source directory != build directory for
> QInfinity. I would recommend building in this way btw :) keeps your
> source directory clean.

Thanks, I just applied and commited the patches.

>
> Anyways in Kobby, I noticed that none of the files have license
> headers. Some examples are at:
> http://techbase.kde.org/Policies/Licensing_Policy
>
> Its a requirement of the GPL that such a license header appear with
> all copyright holders listed.

Wow, I did not know that. Thanks for the heads up.

>
> diff --git a/libqinfinity/CMakeLists.txt b/libqinfinity/CMakeLists.txt
> index ba7d970..02e21b7 100644
> --- a/libqinfinity/CMakeLists.txt
> +++ b/libqinfinity/CMakeLists.txt
> @@ -75,7 +75,7 @@ set(QInfinity_HDRS
>
> QT4_AUTOMOC(${QInfinity_SRCS})
>
> -include_directories(${LIBINFINITY_INCLUDES} ${LIBINFTEXT_INCLUDES})
> +include_directories(${LIBINFINITY_INCLUDES} ${LIBINFTEXT_INCLUDES} $
> {CMAKE_CURRENT_BINARY_DIR})
>
> ADD_LIBRARY(qinfinity SHARED ${QInfinity_SRCS})
>
> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
> index 29a13a2..98c98cb 100644
> --- a/test/CMakeLists.txt
> +++ b/test/CMakeLists.txt
> @@ -4,7 +4,7 @@ find_package(Libinfinity REQUIRED)
> set(QT_USE_QTNETWORK true)
> INCLUDE(${QT_USE_FILE})
>
> -include_directories(${LIBINFINITY_INCLUDES} ${CMAKE_SOURCE_DIR}/
> libqinfinity)
> +include_directories(${LIBINFINITY_INCLUDES} ${CMAKE_SOURCE_DIR}/
> libqinfinity ${CMAKE_CURRENT_BINARY_DIR})
>
> QT4_AUTOMOC(guibrowser.cpp
> connection.cpp

--
Gregory Haynes