Chrome 37 showModalDialog and kwf 3.5

[Artyom M]

Hello!

After Google killed showModalDialog method in Chrome 37 our project on kwf 3.5 not working properly. It freeze until you kill the tab. 

See load.jpg

chrome.exe constantly eats memory....see process.jpg

I do a regedit fix from this link:

http://stackoverflow.com/questions/25663053/how-can-i-make-window-showmodaldialog-work-in-chrome-37

But problem still exists.

Now it works only in Firefox.

p.s. IE freeze and eats memory too.

[Niko Sams]

Hi,

that's a different issue - we don't use showModalDialog.

check developoer console for any errors.

Niko

--
You received this message because you are subscribed to the Google Groups "Koala Framework Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to koala-framework...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Artyom M]

Hmm... coincided with chrome release 37. Strange...

>check developoer console for any errors.

What you mean? F12 in Chrome not work because tab is freeze.

[Niko Sams]

then you have some kind of an endless loop - which also causes the high memory usage.

You could probalby find the cause using firefox...

Niko

--

[Artyom M]

Hello!

Now not work in FF =((

How can I debug this?

what i see in chrome

1. Request URL:
   https://portal.aviashelf.com/flightgroups/json-data
2. Request Headers
1. Provisional headers are shown
2. Content-Type:
   application/x-www-form-urlencoded; charset=UTF-8
3. Origin:
   https://portal.aviashelf.com
4. Referer:
   https://portal.aviashelf.com/
5. User-Agent:
   Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36
6. X-DevTools-Emulate-Network-Conditions-Client-Id:
   D49D41DE-1740-41D0-9384-5051389725E9
7. X-Requested-With:
   XMLHttpRequest
3. Form Dataview sourceview URL encoded
1. meta:
   true
2. flightId:
   4092
3. application_max_assets_mtime:
   1407134012
4. kwfSessionToken:
   901ff1c8124bbda84e54bcfff2993a02

in FF i see responce, but it eats memory now...

Admin.js not work (FF says that I need to debug)

[Artyom M]

Done!

I found interesting bug in this lines of my code:

$tab->fields->add(new Kwf_Form_Field_TimeField('flightStartTime', trlKwf('Start Time')))->setIncrement(5);

$tab->fields->add(new Kwf_Form_Field_TimeField('flightStartActualTime', 'Факт. время'))->setIncrement(5);

After I comment this my project works normal. 

Then I found that this time incremen (setIncremet(5)) is reason of endless loop.

In \library\ext\2.3.0\src\widgets\form\TimeField.js:

// private - This is the date to use when generating time values in the absence of either minValue

// or maxValue.  Using the current date causes DST issues on DST boundary dates, so this is an 

// arbitrary "safe" date that can be any date aside from DST boundary dates.

initDate: '1/1/2008',

// private

    initComponent : function(){

        Ext.form.TimeField.superclass.initComponent.call(this);

        if(typeof this.minValue == "string"){

            this.minValue = this.parseDate(this.minValue);

        }

        if(typeof this.maxValue == "string"){

            this.maxValue = this.parseDate(this.maxValue);

        }

        if(!this.store){

            var min = this.parseDate(this.minValue);

            if(!min){

                min = new Date(this.initDate).clearTime();

            }

            var max = this.parseDate(this.maxValue);

            if(!max){

                max = new Date(this.initDate).clearTime().add('mi', (24 * 60) - 1);

            }

            var times = [];

            while(min <= max){

                times.push([min.dateFormat(this.format)]);

                min = min.add('mi', this.increment);

            }

            this.store = new Ext.data.SimpleStore({

                fields: ['text'],

                data : times

            });

            this.displayField = 'text';

        }

    },

What I see in debug in max and min variables:

min = Tue Jan 01 2008 00:00:00 GMT+1000

max = Tue Jan 01 2008 23:59:00 GMT+1000

when min value set to 23:55 next increment change it to 23:00 and do it again and again => endless loop

I change this:

while(min <= max) {

     times.push([min.dateFormat(this.format)]);

     min = min.add('mi', this.increment);

}

to this:

do {

     times.push([min.dateFormat(this.format)]);

     min = min.add('mi', this.increment);

}

while(min <= max);

It works normal now.

Also I set initDate: '10/26/2014',

[Artyom M]

Finally found a problem and solution.

Problem is KB2998527:

http://support.microsoft.com/kb/2998527

Solution is to change initDate in Ext.js:

initDate: '2/1/2008',

Also about this bug (in russian):

http://habrahabr.ru/post/239423/

http://habrahabr.ru/post/241359/

http://habrahabr.ru/post/241215/

[Niko Sams]

wow, interesting issue.

As this is a problem in ExtJS you could probably check if other versions are also affected.

If your fix is the proper way to solve this problem I can integrate it into our library repository.

cheers,

Niko

[Artyom M]

>As this is a problem in ExtJS you could probably check if other versions are also affected.

I heard there are no problems in ExtJS 4  but it remains to be verified. Do you have plans to migrate on last ExtJS version?

>If your fix is the proper way to solve this problem I can integrate it into our library repository.

Anyway I don't know other methods to solve this problem =))

[Niko Sams]

On Tue, Oct 28, 2014 at 1:39 AM, Artyom M <psycho...@gmail.com> wrote:

>As this is a problem in ExtJS you could probably check if other versions are also affected.

I heard there are no problems in ExtJS 4  but it remains to be verified. Do you have plans to migrate on last ExtJS version?

yes, see here: http://www.nikosams.net/blog/8_ext4_update_plan

 

>If your fix is the proper way to solve this problem I can integrate it into our library repository.

Anyway I don't know other methods to solve this problem =))

--