Defining exec readiness probes for sidecar container
Florian MEDJA
Hello Knative devs,
I reported a bug related to the definition of readiness probes for Knative Serving sidecar containers: https://github.com/knative/serving/issues/15484.
I would like to contribute and submit a merge request. While reviewing the code, I noticed that the exec readiness probe on the main container is executed using a TCP probe. The use of a TCP probe requires specifying a port, which is not possible for a sidecar container. I suspect that the usage of a TCP Probe instead of a Exec probe is related to the fact that the probe is executed through the queue-proxy.
Were there any other technical limitations or advantages that led to executing the exec probe via a TCP probe?
Would it be a good idea to support exec readiness probes for sidecar containers? If so, should it be implemented through the queue-proxy?
