v1.0.5 patch (#1) now available - product section fixes

[Richard Northcott]

I have uploaded a patch in relation to some issues found (mainly to do with MODx v0.9.6.2).

This is a single php file with a simple readme.txt file to explain what it fixes and where the php file must be placed.


Richard

[Ettiene Grobler]

You rock!

2008/9/19 Richard Northcott <richa...@gmail.com>:

[Richard Northcott]

Thanks - hope that means its working or at least you've got further :)

[Ettiene Grobler]

I can add a product now yes! :)

But when I view the specific product page I get this PHP warning:

Warning: Call-time pass-by-reference has been deprecated; If you would
like to pass it by reference, modify the declaration of [runtime
function name](). If you would like to enable call-time
pass-by-reference, you can set allow_call_time_pass_reference to true
in your INI file in
D:\work\wamp\www\modx-0.9.6.2\assets\snippets\shoppingCart\eCart\classes\gButton.php
on line 90

Think it's anything serious, maybe my server config?

Thanks
ETtiene

2008/9/19 Richard Northcott <richa...@gmail.com>:

[Richard Northcott]

Hi Ettiene

Yes it appears to be a server setting.
I have checked my php.ini file (through WAMP) and it is set to

allow_call_time_pass_reference = On

It was good for me to get this as I noticed a potential error with something else that may cause an issue with the creation of the Google button on line 58

$this->_loc     = "en_GB"; //en_US

this of course is not very good as it is hard coded for GB. I have changed the code to

if($_SESSION['eParams']['CountryArea']=="GB") {$this->_loc     = "en_GB";}
            else {$this->_loc = "en_US";}

this should compare the country set under the Site Config area and set to either to en_GB (if country is GB) otherwise to the en_US


Cheers



Richard

[Ettiene Grobler]

Aha thanks.

Ettiene

2008/9/19 Richard Northcott <richa...@gmail.com>:

[Richard Northcott]

thats ok