Creating custom fields on a subscription with KillBillClient

[gpre...@womply.com]

We've used custom fields on account objects before without issue. Now we'd like to create a custom field on a Subscription object.

I can see in SubscriptionResource that there are endpoints to get, create, and delete custom fields, but I don't see those endpoints exposed at all through the java KillBillClient.

It appears the client only exposes custom field methods for accounts, payment methods, and as of a few days ago, payments. But not subscriptions or bundles.

Thanks.

[stephane brossier]

Greg,

It is very likely we are missing those. Feel free to submit a PR (against the version of the client you are using) and we'll take care of the merge.

Stéphane

--
You received this message because you are subscribed to the Google Groups "Kill Bill users mailing-list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to killbilling-users+unsubscribe@googlegroups.com.
To post to this group, send email to killbilling-users@googlegroups.com.
Visit this group at https://groups.google.com/group/killbilling-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/killbilling-users/aa178470-c360-4c84-b258-e1fdbb3ec0b7%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[gpre...@womply.com]

Will do. We're using 0.23.4 currently.

I expect it will look a lot like Pierre's change to add custom fields for payments.

[stephane brossier]

👍

On Tue, Feb 7, 2017 at 2:51 PM, <gpre...@womply.com> wrote:

Will do.  We're using 0.23.4 currently.

I expect it will look a lot like Pierre's change to add custom fields for payments.

--
You received this message because you are subscribed to the Google Groups "Kill Bill users mailing-list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to killbilling-users+unsubscribe@googlegroups.com.
To post to this group, send email to killbilling-users@googlegroups.com.
Visit this group at https://groups.google.com/group/killbilling-users.

To view this discussion on the web visit https://groups.google.com/d/msgid/killbilling-users/2e768f5f-ee5f-428b-9e5f-1148b8f8d795%40googlegroups.com.

[stephane brossier]

Greg,

I created a new branch 'work-for-release-0.16.x' and added the content of your diff here. Could you checkout that branch and confirm the code is working as expected (since we don't have tests here), and then i 'll take care of creating a release '0.23.5' for you and merging that code into master.

Thanks,

Stéphane

On Wed, Feb 8, 2017 at 2:03 PM, Greg Preston <gpre...@womply.com> wrote:

I'm not sure how to create a PR against the 0.23.4 tag, but here's the diff:  https://github.com/killbill/killbill-client-java/compare/killbill-client-java-0.23.4...gpreston-womply:custom-fields-subscriptions

I added the custom fields methods for subscriptions and bundles, based entirely off of Pierre's addition for payments.

-Greg

[Greg Preston]

Thanks.  I've checked out that branch and will use it today.  I'll let you know my results.

-Greg

[gpre...@womply.com]

All of my tests are passing with the work-for-release-0.16.x branch, and I'm creating and reading custom fields on a subscription.

I think it's good to go.

[stephane brossier]

Greg,

I released version  0.23.5.

Thanks for the contribution.

Stéphane