Owners of killbill-email-notification-plugin

[S Ramakrishnan]

Hello...

I am trying to make an enhancement to the killbill email notification plugin

which would allow it to read subscription attributes not persisted in killbill to be

included in the generated invoice.

Questions:

   1) Please let me know if I could have write permission to the repository killbill/kill-bill-email-notification-plugin. I am unable to add reviewers, I believe due to this.

   2) I do not see a contribution.md or some such to help contributors.

   3) I read the suggested approach to add a custom invoice generator in the main page of the plugin. My approach varies only slightly from this; I will align with the suggested approach if you disagree with my PR. 

   4) I have PR 64 in draft stage; please let me know if you would let this merge into master or if I should keep it in a private, company-specific branch off master. Please note that I have deliberately kept this in draft state; its not ready for prime-time.

   5) It looks like this simple need to add subscription attributes to invoices entails customizing killbill, which in turn entails the need to deploy with a custom docker image of killbill. Could this somehow be avoided?

Regards,

Rk

[S Ramakrishnan]

A follow up on integrating the custom invoice formatter: the home page suggests that

the custom invoice formatter factory should be added by registering the factory as a service in the OSGi runtime.

My custom formatter retrieves custom fields from KillBill (using killbill REST client) and 

inserts them into the model (with the corresponding change to the email template

to include the name of the model attribute). This cannot be done simply by registering

the factory with OSGI runtime. Hence I have had to amend org.killbill.billing.plugin/notification.generator.TemplateRenderer.java.

I'd love to be told that this is unnecessary and that "somehow" this would happen automagically.

Regards,

Rk

[Shaun Forgie]

Hi RK,

With respect to the invoice data elements enhancement we were discussing here https://github.com/killbill/killbill/issues/2074 it would make more sense to have the configured meta-data placed/stamped onto the invoice during the normal billing cycle process rather than attempting to post process the invoice and decorate it during email notification and delivery particularly if the invoice needs to be delivered by alternative means...like PEPPOL/eInvoicing networks for example.

Implementing important invoicing meta data functionality in the email delivery plugin seems like a rather obscure way of doing this. From a design perspective, being able to specify what metadata gets placed onto invoices from account and subscription objects is an important core feature that should be independent of the delivery channel.

Thanks for the PR contribution as this is still a much needed feature for email delivery.

Rgs

Shaun

--
You received this message because you are subscribed to the Google Groups "Kill Bill users mailing-list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to killbilling-us...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/killbilling-users/CANpfqgc5aM1%3DGOfEEwM5cVD_vOO81aBnnREpRwrVX8%3DP%3DzOwOA%40mail.gmail.com.

--

Shaun Forgie [Principal] - Method Maker Ltd
57a McIntyre Rd, Manukau 2022, Auckland, New Zealand
Mobile +64 21 666 910 https://www.linkedin.com/in/shaunforgie/