Follow up on Issue 1599

[Victor Medeiros]

Hey, we reported a bug a while back that is currently being tracked on gihthub as issue 1599: https://github.com/killbill/killbill/issues/1599 

Is this fix release or being worked on for kb 0.22.x version? Or has it not been prioritized yet?

thanks

[karan bansal]

Hi Victor,

Thank you for following up. Let me check this with the Dev team and update you.

Regards

Karan

[karan bansal]

Hi Victor,

I checked this with the Dev team. Unfortunately it has not been prioritized yet and there is no ETA at the moment. This would not be backported to 0.22 though, you will need to upgrade to 0.24.

Regards

Karan

[Victor Medeiros]

Thanks Karan!

Since it has not been prioritized and we are seeing the exception quite often on our production environment, would it be possible to get a brief explanation from the team on what the method onSuccess() from InvoicePaymentControlPluginApi.class does for case: PURCHASE? 

here is the reference link: https://github.com/killbill/killbill/blob/697ef54d498854b7887fd9f7d1f33375a91d8317/payment/src/main/java/org/killbill/billing/payment/invoice/InvoicePaymentControlPluginApi.java#L169

From what i understand its checking if the payment actually happened and if it didn't, it updates the table row status to PENDING.
- Doesn't the method onSuccess() already implies the payment succeeded?
- Do you see any potential harm on having the exception being thrown on line 170 due to plugin properties being null? From what we can see the payment and invoices are generated and later updated by AttemptCompletionJanitorTask.

Thank you!

[karan bansal]

Hi Victor,

You are right. The onSuccessCall() method is invoked after the payment operation is executed successfully and returns onSuccessPaymentControlResult to override the list of plugin properties.  Could you please provide more details about what issue are you facing and reason for considering exception at line 170. 

Regards

Karan

[Victor Medeiros]

Hey Karan,

We are seeing that for a large number of recurring payments we get the exception on line 170 because plugin properties is empty. We have a test case where we had 140 recurring payments happening after advancing the clock and we saw this exception happened in 2 out 140 subscriptions. We tried debugging and turns out pluginProperties is empty. The fact that it doesnt always happen might indicate its a race condition as described on issue 1559. 

We are using killbill v0.22.29

Exception stacktrace:

Error during onSuccessCall for plugin='__INVOICE_PAYMENT_CONTROL_PLUGIN__', paymentExternalKey='000000-e28f-49f1-ad39-48280a22f63c'#012org.killbill.billing.control.plugin.api.PaymentControlApiException: Failed to retrieve invoiceId: #012#011at org.killbill.billing.payment.invoice.InvoicePaymentControlPluginApi.getInvoiceId(InvoicePaymentControlPluginApi.java:319)#012#011at org.killbill.billing.payment.invoice.InvoicePaymentControlPluginApi.onSuccessCall(InvoicePaymentControlPluginApi.java:170)#012#011at org.killbill.billing.payment.core.sm.control.ControlPluginRunner.executePluginOnSuccessCalls(ControlPluginRunner.java:203)#012#011at org.killbill.billing.payment.core.sm.control.OperationControlCallback.executePluginOnSuccessCalls(OperationControlCallback.java:208)#012#011at org.killbill.billing.payment.core.sm.control.CompletionControlOperation$1.doOperation(CompletionControlOperation.java:105)#012#011at org.killbill.billing.payment.core.sm.control.CompletionControlOperation$1.doOperation(CompletionControlOperation.java:74)#012#011at org.killbill.billing.payment.core.ProcessorBase$WithAccountLock.processAccountWithLock(ProcessorBase.java:179)#012#011at org.killbill.billing.payment.core.ProcessorBase$CallableWithAccountLock.call(ProcessorBase.java:162)#012#011at org.killbill.billing.payment.core.ProcessorBase$CallableWithAccountLock.call(ProcessorBase.java:143)#012#011at org.killbill.billing.payment.dispatcher.CallableWithRequestData.call(CallableWithRequestData.java:69)#012#011at org.killbill.commons.concurrent.WrappedCallable.call(WrappedCallable.java:45)#012#011at java.util.concurrent.FutureTask.run(FutureTask.java:266)#012#011at org.killbill.commons.concurrent.WrappedRunnable.run(WrappedRunnable.java:49)#012#011at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)#012#011at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)#012#011at java.lang.Thread.run(Thread.java:750)#012Caused by: org.killbill.billing.payment.api.PaymentApiException: Plugin exception Need to specify a valid invoiceId in property IPCD_INVOICE_ID#012#011

[karan bansal]

Hi Victor,

Thank you for explaining this. Let me discuss this with Devs further and get back with more information.

Regards

Karan

[Victor Medeiros]

Hey karan!

Any updates on this? Seems like plugin properties is not being serialized/is null by the time it reaches the onSuccess() method. 

Thanks! 

[Sachin Jain]

Hello Karan,

Any updates on this? 

Thanks,

Sachin

[karan bansal]

Hi Sachin,

I have sent a follow up to the Dev team, will update here as soon as I get more details.

Regards

Karan

[Nick Mancuso]

Hello all,

We are also running into this issue after some configuration changes in our deployment. 

> Do you see any potential harm on having the exception being thrown on line 170 due to plugin properties being null? 

I am wondering the same ^

Best,

Nick