Demos repo

[Lucas Ponce]

Talking with Alberto he suggested me if we want to a kiali repo for demos.

I'm +1 for that.

I know we have a couple of pair demos there (Joel's soccer one, Travels Demo) and not sure if there are others there.

This work started as a very pet project without following any strong guidelines, just for being used in an article, or a presentation. (also as a side goal of self-learning other things).

But if people like the idea we can formalize it to create a demos repo under kiali, tidy up things and try to document them well to be used in more scenarios.

What do you think ?

  

[Alberto Gutierrez]

+100

--
You received this message because you are subscribed to the Google Groups "kiali-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kiali-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/CAGUuq3VgLjz4uu0wqBLPmoUh9Vye1-S_X%3DP1oJLrXnhZp2miug%40mail.gmail.com.

--

ALBERTO GUTIERREZ

Red Hat Inc

agut...@redhat.com

[Mike Thompson]

I think a demo repo would be great!!

To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/CAH2rVmEg_mWsh4u5mu6m6%3D9oSy_XfqttBbM1yJMwuYvRnSFiug%40mail.gmail.com.

[Serena Chechile Nichols]

This is a great idea!  I know a lot of the dev advocates and SAs are looking for existing demos

To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/CACms5ttovOiJa%3DK_RqbKu00%3Ddde9P4yRfc6_3X2WeTB_xnkgpw%40mail.gmail.com.

[Lucas Ponce]

A demos repo has been created under:

https://github.com/kiali/demos

I've migrated the "travels" app to not use personal github accounts and repo, I think now it's more clean and it's more open for participation.

No strong rules, only a couple of basic ones:

- Let's be clean, the demos repos - of this and every project you may find in github - tend to be abandoned easily and it's easy that at some point it requires changes. Cleaner it is, easier to maintain.

- It's a demo repo, open for experiments but I suggest keeping the dependencies and requirements minimal to invite others to collaborate.

- A folder per new app, with some common ways to build/deploy/clean, you can use the travels as an example.

- Again, don't over-arch, if one demo uses a build.sh, don't force a user to install pip, to update a python3, to install ansible,  to basically perform a build, if there is a .sh that you can reuse.

Have fun.

Please, let me know if there is any problem to fix it, but I think that the migration from my personal github to kiali should be done.

Thanks

To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/CAJxcuqCkOGvBJPn64mVENHJk1EfDU1OPDWVjna18txBsxQxa5Q%40mail.gmail.com.

[Alberto Gutierrez]

Hooray !!!

[John Mazzitelli]

> - Again, don't over-arch, if one demo uses a build.sh, don't force a user
> to install pip, to update a python3, to install ansible, to basically
> perform a build, if there is a .sh that you can reuse.

I like when things use docker containers to build and run. That's how I have the molecule integrations tests now, for example. You do not have to install pip, python or anything else like that on your machine - the docker image is built with all of that inside and you run molecule from within docker containers.

That's how we should do things to avoid asking people to have the correct version of python installed, or any other required third party lib.

[John Mazzitelli]

Of course, this also means you need to have the correct docker or podman.

Note - do not assume everyone has podman :)

https://github.com/kiali/demos/pull/1#pullrequestreview-465247760

> --
> You received this message because you are subscribed to the Google Groups
> "kiali-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to kiali-dev+...@googlegroups.com.
> To view this discussion on the web visit

> https://groups.google.com/d/msgid/kiali-dev/1632145132.7492225.1597164192356.JavaMail.zimbra%40redhat.com.
>
>

[jsti...@redhat.com]

It might be a good idea to provide some documentation (says the docs person):

1) include something like Lucas's basic demo guidelines in the README for the repo (keep the architecture simple, what would be expected to have a PR accepted to the demo, etc.)

2) include a README for each demo with similar notes about what you need to run the demo (as I see Lucas has already done).

[Alberto Gutierrez]

On Tue, Aug 11, 2020, 6:59 PM jsti...@redhat.com <jsti...@redhat.com> wrote:

It might be a good idea to provide some documentation (says the docs person):

1) include something like Lucas's basic demo guidelines in the README for the repo (keep the architecture simple, what would be expected to have a PR accepted to the demo, etc.)

2) include a README for each demo with similar notes about what you need to run the demo (as I see Lucas has already done).

 +1

I'll contribute here to provide useful demos for kiali ;) we needed it !!!

To view this discussion on the web visit https://groups.google.com/d/msgid/kiali-dev/6d8fdfd0-2fb8-4c30-b5ea-96f17bf0e597n%40googlegroups.com.