Log4J dependency should be replaced by slf4j

[Will Sargent]

Hi all,

I've got a free weekend, so I'm going through some KeyCzar issues.

KeyCzar 0.71f depends on Log4J.  This is a problem, as most projects have moved to SLF4J as a good lowest common denominator, and use either Log4J 2 or Logback as the logging engine.

It looks like there's a PR open for it from 2013.

https://github.com/google/keyczar/issues/112

but it hasn't been applied.

I'm happy to add the work to submit a new PR, if the old one is no longer applicable.

Will.

[Shawn Willden]

I looked at this a while ago and I recall that there seemed to be some issues with the PR.

If you'd like to update it, I'll review and apply it. Thanks!

BTW, sorry for the slow response, I've been traveling.

--
You received this message because you are subscribed to the Google Groups "Keyczar Discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to keyczar-discu...@googlegroups.com.
To post to this group, send email to keyczar...@googlegroups.com.
Visit this group at http://groups.google.com/group/keyczar-discuss.
For more options, visit https://groups.google.com/d/optout.

[Will Sargent]

Looks like I mistakenly checked out "java_release_0.71f" instead of "Java_Release_0.71g" (the upper casing threw me off).

All the log statements in 0.71g are removed, and SLF4J is being used there, as of

https://github.com/google/keyczar/commit/d4880f06488bad5ac5396266022ad331db6b3066