Implement tolerations when deployin Keycloak using Operator

[davidh]

Hi,

I need to deploy Keycloak in an on-premise kubernetes using the Keycloak Operator. However, my nodes in the cluster require tolerations on any Deploymentsor Statefulset.

I saw that the issue KEYCLOAK-18547 has been opened that corresponds to my needs with no comments or PR yet.

I have experience with Kubernetes operators using Operator SDK so I would like to discuss with the community to try to implement this feature.

By looking at the operator's source code, I already noticed that in keycloak_types.go we could add tolerations in the type DeploymentSpec. Then we can add in the Keycloak deployment's model the tolerations in the statefulset based on the spec. We can do so for the Postgres database as well but didn't check it out yet since I am using an external database. 

Note: I am not sure with the dev mail list is the place to discuss code implementation

I am looking forward to this discussion and hope we can achieve the implementation of this feature rapidly.

[Václav Muzikář]

Hello,

thanks for reaching out. Yes, this is the correct ML to discuss implementation. It makes sense to add this. However, only to the Keycloak/RH-SSO StatefulSet, not to the embedded DB as we plan to remove it in the future in any case [1].

A contribution would be much appreciated! :)

[1] https://issues.redhat.com/browse/KEYCLOAK-15493

--
You received this message because you are subscribed to the Google Groups "Keycloak Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to keycloak-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/keycloak-dev/dea50621-6182-4053-b485-21dc6cacbeb4n%40googlegroups.com.

--

Václav Muzikář
Senior Software Engineer
Keycloak / Red Hat Single Sign-On
Red Hat Czech s.r.o.

[davidh]

Hello,

Alright I agree on the fact to add the feature only on the Keycloak/RH-SSO StatefulSet. I am planning to start working on the feature in the next days.

[Sebastian Łaskawiec]

Keep in mind that you can use a Mutating Webhook to add whatever is needed into Keycloak or Postgresql StatefulSet/Deployment.

To view this discussion on the web visit https://groups.google.com/d/msgid/keycloak-dev/1900bd1d-cc87-4a1c-afe4-c1fda0cd5ea7n%40googlegroups.com.

--

Sebastian Łaskawiec

[davidh]

I didn't know we can use mutation webhook in this case, but I think it's like using a sledgehammer to crack a peanut.

[davidh]

Pull request done but need reviewers to launch the CI/CD workflows: https://github.com/keycloak/keycloak-operator/pull/401