Entry colors

[Josef Vítů]

Hi! I'd like to implement showing and editing of the bg/fg color property of the entries, and I have some questions regarding that.

Drawing colored rows is straightforward, as it's just about adding a few lines to EntryModel::data (I have a patch already), but I'm not sure where would be the best place to allow editing of these properties. One obvious place is the "Properties" tab, but it's implemented using an abstraction (EditWidgetProperties class) to make it somewhat read-only. I could certainly add some getters/setters, but I don't like that solution much in this case...

Another option would be removing that abstraction class and use a QScopedPointer<Ui::EditWidgetProperties> directly in the EditEntryWidget class, as is the case with the remaining tabs (Advanced, History etc.), but that would add more logic to EditEntryWidget.

The third option is to place the color settings to another tab. But which? (Of course, the code bloat in EditEntryWidget would happen here as well.)

Then the second set of questions: KeePass allows quickly setting one of four predefined bg colors from an entry's context menu. Do we want to implement it that way in KeePassXR too? Using the same colors? Or do you have another idea how to handle it?

Thanks in advance for any input.

[TheZero]

I think this is a nice feature but low priority right now.

How about the "Icon" section? We can change it to "Style" or "Personalization" and add also the color settings to "gui/EditWidgetIcons.ui"

[Josef Vítů]

Yeah, I suppose there are more important things to do right now. I'll add an issue to the tracker on Github, so it won't get forgotten, and keep the patches in my repository for the time being. Would that be alright?

And thanks for the suggestion, that might be the right place.

[TheZero]

Don't get me wrong, If you want to implement the Entry Colors you are free to do so. :)

I've said so because we have lot of opened Issue that are high priority and help is always welcomed :)

[Josef Vítů]

Oh, I see :) OK, will do that. I currently don't have much time on my hands, so I'm just "fixing" what concerns me the most, but I'll try to contribute a little more in the future if I'm able to.

[droidmonkey]

If you want to start a Pull Request feel free to do so. You can add a task list of things to complete and keep adding to the branch and it'll update. That's a great way to keep track of it.