Review Request: Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

[Daniele Elmo Domenichelli]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/

Review request for kdelibs. By Daniele Elmo Domenichelli. Summary (updated) Fix KWidgetItemDelegate not updating on FocusIn and FocusOut Description (updated) KWidgetItemDelegate does not update when the itemView gets or loses the focus. This may cause problems with the text colors of the selected indexes. I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items. Diffs (updated) kdeui/itemviews/kwidgetitemdelegate.cpp (828e498) View Diff

[Jeremy Paul Whiting]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/

Ship it!

Ship It!

- Jeremy Paul

On March 4th, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote:

Review request for kdelibs. By Daniele Elmo Domenichelli.

Updated March 4, 2012, 2:58 a.m. Description

KWidgetItemDelegate does not update when the itemView gets or loses the focus. This may cause problems with the text colors of the selected indexes. I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items. Diffs

kdeui/itemviews/kwidgetitemdelegate.cpp (828e498) View Diff

[Commit Hook]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/

This review has been submitted with commit 11c7c9adcce7f476b32128f104e2935c6e19ac9d by Daniele E. Domenichelli to branch KDE/4.8.

- Commit

On March 4th, 2012, 2:58 a.m., Daniele Elmo Domenichelli wrote:

Review request for kdelibs. By Daniele Elmo Domenichelli.

Updated March 4, 2012, 2:58 a.m. Description KWidgetItemDelegate does not update when the itemView gets or loses the focus. This may cause problems with the text colors of the selected indexes. I'm not sure if this is the best way to do it, since in all the other places this is done asyncronously using "QTimer::singleShot(0, this, SLOT(initializeModel()))", but this initializes the whole model, and I think it is not needed here. The alternatives are to update the whole model, or to add another slot to initialize only selected items. Diffs kdeui/itemviews/kwidgetitemdelegate.cpp (828e498) View Diff