Review Request: KJS: Implement Object.GetPrototypeOf, Object.GetOwnPropertyDescriptor, Object.DefineProperty

1 view

Skip to first unread message

Bernd Buschinski

unread,

Mar 12, 2012, 5:08:49 PM3/12/12

to kdelibs, Bernd Buschinski

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104244/

Review request for kdelibs.

By Bernd Buschinski.

Description

KJS: Implement Object.GetPrototypeOf, Object.GetOwnPropertyDescriptor, Object.DefineProperty

With this ECMAScript is down to 2855 fails.
The remaining DefineProperty fails are because of Array&String need
some special implementation for that(according to ecma), also because of currently not implemented Extensible.
In combination with a function prototype it also fails, but that is a bug somewhere else.

New PropertyDescriptor collects and manages proptery attributes according to ecma.

Testing

Tested with ecmascript262, reduces fails to 2855, about 2000 fails less than without this patch.

Diffs

kjs/CMakeLists.txt (1188064)
kjs/CommonIdentifiers.h (8ee40e8)
kjs/object.h (047c242)
kjs/object.cpp (c19122f)
kjs/object_object.cpp (986f03f)
kjs/propertydescriptor.h (PRE-CREATION)
kjs/propertydescriptor.cpp (PRE-CREATION)