Re: Review Request: Make sure there is a whitespace after the colon in Content-Type header line

[Dawit Alemayehu]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

Ship it!

Ship It!

- Dawit

On March 11th, 2012, 11:37 a.m., Andrea Iacovitti wrote:

Review request for kdelibs, Dawit Alemayehu and David Faure. By Andrea Iacovitti. Updated March 11, 2012, 11:37 a.m. Description Make sure there is a whitespace after the colon in Content-Type header line. This is not mandatory as of RFC 2616 but it could cause problem on some http server (bug 295305). Testing Using WebKit engine in konqueror the value of content-type metaData is set to "application/x-www-form-urlencoded" ending up to the following content-type http header line sent to the server "Content-Type:application/x-www-form-urlencoded" (so i suppose the bug reporter was using WebKit engine) The problem doesn't affect KHTML engine that sets content-type metadaData to "Content-type: application/x-www-form-urlencoded" Bugs: 295305 Diffs kioslave/http/http.cpp (40d10e2) View Diff

[Dawit Alemayehu]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

Oops. I meant provide a review. I rather you do not include the .trimmed() statement for now because I am not entirely sure something else might now break. Just adding the white space after "Content-Type"  should be enough to fix the stated bug.

[Dawit Alemayehu]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

Ship it!

Ship It!

- Dawit

On March 11th, 2012, 8:49 p.m., Andrea Iacovitti wrote:

Review request for kdelibs, Dawit Alemayehu and David Faure. By Andrea Iacovitti.

Updated March 11, 2012, 8:49 p.m.

[Andrea Iacovitti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

Review request for kdelibs, Dawit Alemayehu and David Faure. By Andrea Iacovitti.

Updated March 11, 2012, 11:37 a.m.

[Andrea Iacovitti]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

Review request for kdelibs, Dawit Alemayehu and David Faure. By Andrea Iacovitti.

Updated March 11, 2012, 8:49 p.m. Changes removed the trimmed() statement

Description Make sure there is a whitespace after the colon in Content-Type header line. This is not mandatory as of RFC 2616 but it could cause problem on some http server (bug 295305). Testing Using WebKit engine in konqueror the value of content-type metaData is set to "application/x-www-form-urlencoded" ending up to the following content-type http header line sent to the server "Content-Type:application/x-www-form-urlencoded" (so i suppose the bug reporter was using WebKit engine) The problem doesn't affect KHTML engine that sets content-type metadaData to "Content-type: application/x-www-form-urlencoded" Bugs: 295305

Diffs (updated) kioslave/http/http.cpp (40d10e2) View Diff

[Commit Hook]

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104221/

This review has been submitted with commit 5bc91690dff7c3608d3ca2cb285140a86002f4ca by Andrea Iacovitti to branch KDE/4.8.

- Commit

On March 11th, 2012, 8:49 p.m., Andrea Iacovitti wrote:

Review request for kdelibs, Dawit Alemayehu and David Faure. By Andrea Iacovitti. Updated March 11, 2012, 8:49 p.m.

Description

Make sure there is a whitespace after the colon in Content-Type header line. This is not mandatory as of RFC 2616 but it could cause problem on some http server (bug 295305). Testing Using WebKit engine in konqueror the value of content-type metaData is set to "application/x-www-form-urlencoded" ending up to the following content-type http header line sent to the server "Content-Type:application/x-www-form-urlencoded" (so i suppose the bug reporter was using WebKit engine) The problem doesn't affect KHTML engine that sets content-type metadaData to "Content-type: application/x-www-form-urlencoded" Bugs: 295305 Diffs

kioslave/http/http.cpp (40d10e2) View Diff