Review Request: KJS: Extend strictEqual check for numbers by NaN and signbit check

5 views
Skip to first unread message

Bernd Buschinski

unread,
Mar 21, 2012, 8:09:15 PM3/21/12
to kdelibs, Bernd Buschinski
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104358/

Review request for kdelibs.
By Bernd Buschinski.

Description

In c++ NAN == NAN return false, true in javascript 9.12 Step 4.a
also +0 == -0 is true in c++, false in javascript 9.12 Step 4.b (same for -0 == +0 , Step 4c)

Testing

Tesed via ecmascript, fixes some tests that rely on +0 not beeing the same as -0

Diffs

  • kjs/operations.cpp (d4c0066)

View Diff

Bernd Buschinski

unread,
Mar 21, 2012, 8:41:49 PM3/21/12
to kdelibs, Bernd Buschinski
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104358/

Review request for kdelibs.
By Bernd Buschinski.

Updated March 22, 2012, 12:41 a.m.

Changes

Whoops sorry, wrong/old version uploaded
 - now really check for NaN using isNan

Description

In c++ NAN == NAN return false, true in javascript 9.12 Step 4.a
also +0 == -0 is true in c++, false in javascript 9.12 Step 4.b (same for -0 == +0 , Step 4c)

Testing

Tesed via ecmascript, fixes some tests that rely on +0 not beeing the same as -0

Diffs (updated)

  • kjs/operations.cpp (d4c0066)

View Diff

Reply all
Reply to author
Forward
0 new messages