Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

1 view

Skip to first unread message

Bernd Buschinski

unread,

Mar 12, 2012, 5:03:36 PM3/12/12

to kdelibs, Bernd Buschinski

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/

Review request for kdelibs.

By Bernd Buschinski.

Description

KJS/Grammar: Introduce new non-terminal IdentifierName,
which allows keywords to be used as PropertyName, in Memberexps and CallExpr.
(but not yet enum,export,extends, super, because they have the same value RESERVED)

Testing

Tested with ecmascript262, all keyword cases pass now, except the reserved ones

Diffs

kjs/grammar.h (2a006df)
kjs/grammar.cpp (32dbeae)
kjs/grammar.y (d5e835f)

View Diff

Maks Orlovich

unread,

Mar 20, 2012, 5:30:21 PM3/20/12

to Maks Orlovich, kdelibs, Bernd Buschinski

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/

Can I presume this change doesn't changer # of conflicts?

kjs/grammar.y (Diff revision 1)

212	\| IDENT IDENT '(' ')' {inFuncExpr()} FunctionBody {	253	\| IDENT IdentifierName '(' ')' {inFuncExpr()} FunctionBody {

Do we have a bug here with numeric setters/getters? (Unrelated to your CL)

- Maks

On March 12th, 2012, 9:03 p.m., Bernd Buschinski wrote:

Review request for kdelibs.

By Bernd Buschinski.

Updated March 12, 2012, 9:03 p.m.

Bernd Buschinski

unread,

Mar 21, 2012, 8:17:49 PM3/21/12

to Maks Orlovich, kdelibs, Bernd Buschinski

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/

On March 20th, 2012, 9:30 p.m., Maks Orlovich wrote:
Can I presume this change doesn't changer # of conflicts?

I don't understand what conflicts you mean. If you mean failing tests in ecmascript262, it does change the number, it recudes the fails by ~50