Review Request: Limit KDateComboBox date keywords to the date range set for the widget

1 view
Skip to first unread message

David Jarvie

unread,
Mar 8, 2012, 6:04:39 PM3/8/12
to John Layt, kdelibs
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104198/

Review request for kdelibs and John Layt.
By David Jarvie.

Description

Currently, all configured date keywords are displayed in the date picker popup, including keywords for dates which lie outside the set date range and which are therefore invalid for selection. This patch hides keywords for dates earlier than the minimum date, or later than the maximum date. This is the fix discussed at the KDEPIM meeting.

Testing

Tested using KAlarm for minimum date of today or later.

Diffs

  • kdeui/widgets/kdatecombobox.cpp (74b54f2)

View Diff

John Layt

unread,
Mar 12, 2012, 4:50:50 PM3/12/12
to John Layt, kdelibs
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104198/

Ship it!

Ship It!

- John


On March 8th, 2012, 11:04 p.m., David Jarvie wrote:

Review request for kdelibs and John Layt.
By David Jarvie.

Updated March 8, 2012, 11:04 p.m.

Commit Hook

unread,
Mar 13, 2012, 5:39:54 PM3/13/12
to John Layt, Commit Hook, kdelibs
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104198/

This review has been submitted with commit 5f725649429e1184ec3b626f23751b46239a5d3b by David Jarvie to branch KDE/4.8.

- Commit


On March 8th, 2012, 11:04 p.m., David Jarvie wrote:

Review request for kdelibs and John Layt.
By David Jarvie.

Updated March 8, 2012, 11:04 p.m.

Description

Reply all
Reply to author
Forward
0 new messages