[PATCH] kasan, mm: fix build issue with asmlinkage

0 views
Skip to first unread message

Valdis Klētnieks

unread,
Nov 26, 2020, 10:00:18 AM11/26/20
to Russell King - ARM Linux admin, Andrey Ryabinin, kasa...@googlegroups.com, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org
commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
Author: Andrey Konovalov <andre...@google.com>
Date: Tue Nov 24 16:45:08 2020 +1100

kasan: shadow declarations only for software modes

introduces a build failure when it removed an include for linux/pgtable.h
It actually only needs linux/linkage.h

Test builds on both x86_64 and arm build cleanly

Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
Signed-off-by: Valdis Kletnieks <valdis.k...@vt.edu>

---
diff --git a/include/linux/kasan.h b/include/linux/kasan.h
index 83860aa4e89c..5e0655fb2a6f 100644
--- a/include/linux/kasan.h
+++ b/include/linux/kasan.h
@@ -12,6 +12,7 @@ struct task_struct;

#ifdef CONFIG_KASAN

+#include <linux/linkage.h>
#include <asm/kasan.h>

/* kasan_data struct is used in KUnit tests for KASAN expected failures */


Marco Elver

unread,
Nov 30, 2020, 4:46:14 AM11/30/20
to Valdis Klētnieks, Andrew Morton, Andrey Konovalov, Russell King - ARM Linux admin, Andrey Ryabinin, kasan-dev, Linux ARM, LKML
On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.k...@vt.edu> wrote:
> commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> Author: Andrey Konovalov <andre...@google.com>
> Date: Tue Nov 24 16:45:08 2020 +1100
>
> kasan: shadow declarations only for software modes
>
> introduces a build failure when it removed an include for linux/pgtable.h
> It actually only needs linux/linkage.h
>
> Test builds on both x86_64 and arm build cleanly
>
> Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> Signed-off-by: Valdis Kletnieks <valdis.k...@vt.edu>

Reviewed-by: Marco Elver <el...@google.com>

Probably want to add

Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/

for more context, too.

Thanks,
-- Marco



> ---
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 83860aa4e89c..5e0655fb2a6f 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -12,6 +12,7 @@ struct task_struct;
>
> #ifdef CONFIG_KASAN
>
> +#include <linux/linkage.h>
> #include <asm/kasan.h>
>
> /* kasan_data struct is used in KUnit tests for KASAN expected failures */
>
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.

Andrey Konovalov

unread,
Nov 30, 2020, 10:21:53 AM11/30/20
to Valdis Klētnieks, Andrew Morton, Russell King - ARM Linux admin, Andrey Ryabinin, kasan-dev, Linux ARM, LKML, Marco Elver
On Mon, Nov 30, 2020 at 10:46 AM Marco Elver <el...@google.com> wrote:
>
> On Thu, 26 Nov 2020 at 16:00, Valdis Klētnieks <valdis.k...@vt.edu> wrote:
> > commit 2df573d2ca4c1ce6ea33cb7849222f771e759211
> > Author: Andrey Konovalov <andre...@google.com>
> > Date: Tue Nov 24 16:45:08 2020 +1100
> >
> > kasan: shadow declarations only for software modes
> >
> > introduces a build failure when it removed an include for linux/pgtable.h
> > It actually only needs linux/linkage.h
> >
> > Test builds on both x86_64 and arm build cleanly
> >
> > Fixes: 2df573d2ca4c ("kasan: shadow declarations only for software modes")
> > Signed-off-by: Valdis Kletnieks <valdis.k...@vt.edu>
>
> Reviewed-by: Marco Elver <el...@google.com>
>
> Probably want to add
>
> Link: https://lore.kernel.org/linux-arm-kernel/24105.1606397102@turing-police/
>
> for more context, too.

Reviewed-by: Andrey Konovalov <andre...@google.com>

Thank you, Valdis!
Reply all
Reply to author
Forward
0 new messages